225885 - nsPresShell::DoCopy does not work if the focus is outside the window

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Marco Pesenti Gritti]

That is a problem for gtk embedding. In Gtk when you show a context menu the
focus goes outside the window, so currently it's not possible to have Cut/Copy
entries in context menu. I cant see any problem to allow to Copy also when the
focus is not inside the target window (there is a focus memory that keep track
of the last focused control ...).

Comment 1

[Marco Pesenti Gritti]

Attachment: Use FocusController to get the focused element, so it works also if the focus is no more in the window

Comment 2

[Boris Zbarsky [:bzbarsky]]

Note that this patch won't build in a current tree, since the signature of
GetScriptGlobalObject has changed.

Also do_QueryInterface is null-safe, so no need to null-check focusedElement

Comment 3

[Marco Pesenti Gritti]

Attachment: update for mozilla head and remove unnecessary NULL check

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 135708 [details] [diff] [review]
update for mozilla head and remove unnecessary NULL check

r=bzbarsky

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 135708 [details] [diff] [review]
update for mozilla head and remove unnecessary NULL check

Looks good, modulo any lurking bugs with the focus state being out of sync.

Comment 6

[Marco Pesenti Gritti]

Comment on attachment 135708 [details] [diff] [review]
update for mozilla head and remove unnecessary NULL check

It would be good to get this in for 1.6b, so we can make sure during the beta
test phase that there are not bugs with the focus state (agreed with bryner
too).
The fix is pretty important for the GNOME web browser that will probably base
his next release on 1.6.

Comment 7

[Brendan Eich [:brendan]]

bryner: this patch suggests that manager->GetFocusedContent() is a crock, as it
lacks a window-ish parameter.  True?

/be

Comment 8

[Brendan Eich [:brendan]]

bryner: see last comment.

/be

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Also, bryner, what do you think the risk of this patch is (for 1.6b consideration)?

Comment 10

[[e-mail]]

Fix checked in.