Closed
Bug 225911
Opened 22 years ago
Closed 22 years ago
simplify nsHTMLReflowState::DetermineFrameType
Categories
(Core :: Layout: Block and Inline, defect)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(1 file)
|
8.25 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
nsHTMLReflowState::DetermineFrameType should really be InitFrameType, and there
only needs to be one version of it.
|
Assignee | |
Comment 1•22 years ago
|
||
|
|
Assignee | |
Updated•22 years ago
|
Attachment #135677 -
Flags: superreview?(bz-vacation)
Attachment #135677 -
Flags: review?(bz-vacation)
|
||
Comment 2•22 years ago
|
||
Comment on attachment 135677 [details] [diff] [review]
patch
r+sr=bzbarsky, but why do we need the |disp| local var? Just for readability?
Either way (with direct access to mStyleDisplay or with disp) is fine with me.
Attachment #135677 -
Flags: superreview?(bz-vacation)
Attachment #135677 -
Flags: superreview+
Attachment #135677 -
Flags: review?(bz-vacation)
Attachment #135677 -
Flags: review+
|
|
Assignee | |
Comment 3•22 years ago
|
||
I left it as-is since it means the compiler doesn't have to reload the member
variable each time.
Fix checked into trunk, 2003-11-16 16:35 -0800.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•