225972 - GetMIMEInfoForExtensionFromDS returns success even if nothing was found

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

this should set rv to failure if !contentTypeNodeResource, or soemthing like that.

Comment 1

[Nicholas Allen]

If !contentTypeNodeResource then shouldn't the rv for GetSource have been
NS_RDF_NO_VALUE?

Comment 2

[Boris Zbarsky [:bzbarsky]]

NS_RDF_NO_VALUE is a success code.  See
http://lxr.mozilla.org/seamonkey/source/rdf/base/public/rdf.h#87

Comment 3

[Nicholas Allen]

Ah, thanks for pointing that out.  Many of the rdf idl descriptions say that
anything but NS_OK indicates failure, so I thought that applied here as well.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

nallen: There are more success codes than NS_OK. In fact, about half of the
possible nsresults are success codes.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 135735 [details] [diff] [review]
patch

this one is not sufficient...

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

well, I have _no_ idea why I removed this line (readded here in hunk 2). it was
kinda critical.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 135737 [details] [diff] [review]
patch v2

bz, could I get r+sr? this should go in before the freeze...

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 135737 [details] [diff] [review]
patch v2

Oops.  ;)  r+sr=bzbarsky.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

thanks,
Checking in nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <-- 
nsExternalHelperAppService.cpp
new revision: 1.231; previous revision: 1.230
done