225988 - DRefTool analysis for stopwatch files

Status: RESOLVED FIXED

(Core Graveyard :: Tracking, defect)

Description

[timeless]

Bugs:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/modules/libutil/src/stopwatch.cpp&rev=1.18&mark=87#82   
Deref-error: "state"
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/modules/libutil/src/stopwatch.cpp&rev=1.18&mark=88#83   
Deref-error: "mSavedStates"

Comment 1

[timeless]

Attachment: check for alloc failure (and don't use PR_ASSERT)

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+    mSavedStates->PushFront((void*) state);
This is executed even if mSavedStates is null. I think you should return if
mSavedStates couldn't be allocated.

Comment 3

[timeless]

Attachment: properly check for alloc failure (and don't use PR_ASSERT)

Comment 4

[timeless]

checked in