226011 - annoying warning in nsGREDirServiceProvider::GetFile

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GRE Core, defect)

Description

[Axel Hecht]

nsresult rv = NS_ERROR_FAILURE;
...
  if(strcmp(prop, NS_GRE_DIR) == 0)
  {
    rv = GRE_GetGREDirectory(getter_AddRefs(localFile));
  }    
  
  NS_ENSURE_SUCCESS(rv, rv);

creates a lot of annoying warnings.

The rv decleration and handling should be probably inside the if alltogether.

Comment 1

[Benjamin Smedberg]

Attachment: Remove the bogus warning

Yeah, I got a little to NS_ENSURE-happy there...

--BDS

Comment 2

[Benjamin Smedberg]

Doug, I would really like to get this in for beta... it's not a critical
crasher, but anyone who builds a debug build from source would see these
warnings constantly.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 135755 [details] [diff] [review]
Remove the bogus warning

do you even need the "nsresult rv".  You probably can just:

return GRE_GetGREDirectory(...);

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 135755 [details] [diff] [review]
Remove the bogus warning

a=mkaply

Comment 5

[Benjamin Smedberg]

Fixed with a bustage fix: my system allowed me to cast from nsIFile** to
nsILocalFile** but it's bad, so I had to introduce a nsILocalFile* local var.

--BDS