226045 - RegExp toSource/toString return an invalid empty RE

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Phil Schwartau]

SpiderMonkey recently changed the behavior of toString() and toSource()
when applied to a RegExp object with an empty pattern. Do we want 
Rhino to stay in synch?

This is the Rhino analogue of bug 225550 against SpiderMonkey.
The testcases for this are:

      mozilla/js/testsecma_2/RegExp/properties-001.js
      mozilla/js/testsjs1_2/regexp/toString.js


Here is a comparison of the current SpiderMonkey and Rhino:

RHINO:
[/] java org.mozilla.javascript.tools.shell.Main
Rhino 1.5 release 5 0000 00 00
js> (new RegExp).toString();
//
js> (new RegExp).toSource();
//


SPIDERMONKEY:
[//d/JS_TRUNK/mozilla/js/src/WINNT4.0_DBG.OBJ] ./js
js>
js> (new RegExp).toString();
/(?:)/
js> (new RegExp).toSource();
/(?:)/


The new approach lets eval() turn this string back into the empty regexp.
The old approach doesn't work, since "//" is a comment, not a regexp.

Comment 1

[Phil Schwartau]

Oops, those tests are

      mozilla/js/tests/ecma_2/RegExp/properties-001.js
      mozilla/js/tests/js1_2/regexp/toString.js

Comment 2

[Igor Bukanov]

I will fix it.

Comment 3

[Igor Bukanov]

Attachment: Fix for NativeRegExp.toString()

Comment 4

[Igor Bukanov]

I committed the fix

Comment 5

[Phil Schwartau]

Verified FIXED.

The above testcases used to fail in both the compiled and interpreted
modes of Rhino. Now they pass in both -

Comment 6

[Igor Bukanov]

Trageting as resolved against 1.5R5