226059 - nsITransferable* nsClipboard::GetTransferable() returns an addrefed raw pointer

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

There are four implementations of nsClipboard::GetTransferable(), all of which 
return an |nsITransferable*| which has been addrefed.  This contributes to at
least one leak:

http://lxr.mozilla.org/mozilla/source/widget/src/xlib/nsClipboard.cpp#188

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Possible patch

Don't addref if you don't advertise it.  I left most of the callers keeping
strong pointers though, since it is not clear to me on a quick pass that the
member transferables can't go away in between calls.

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Oops, I meant to point to this with my initial bug comment:

http://lxr.mozilla.org/mozilla/source/widget/src/xlib/nsClipboard.cpp#317
317   NS_IF_RELEASE(mTransferable);
318   mTransferable = GetTransferable(aWhichClipboard);
319   NS_ASSERTION(!mTransferable,"mTransferable is null!! see bug 80181");
320   if (!mTransferable) return NS_ERROR_FAILURE;
321   NS_ADDREF(mTransferable);

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in