226123 - Add configurable function list to DRefTool and limit |new| to c++

Status: RESOLVED FIXED

(Core Graveyard :: Tracking, defect)

Description

[timeless]

The original list of functions didn't scale well.
You had to manually hack the list, which was annoying, especially when each 
module has its own strdup (or three in the case of libical). I'm also fixing a 
monitor glitch per dbaron in this patch and improving the html output.

Comment 1

[timeless]

Attachment: configurable function list, |new| for cpp only

Comment 2

[[e-mail]]

Comment on attachment 135834 [details] [diff] [review]
configurable function list, |new| for cpp only

>Index: main.cpp
>===================================================================
>@@ -822,10 +834,12 @@
> 
>           default:
>             fprintf(stderr,
>-                    "Usage: dreftool [-h] [-d sourcepath]\n"
>+                    "Usage: dreftool [-h] [-s] [-f wordlist] [-d sourcepath]\n"
>                     "-d path to root of source tree\n"
>+                    "-f list of functions which can return null\n"

"file containing list of functions..." ?

>+                    "-h emit as HTML\n"
>                     "-s sloppy mode no warnings if member variables are used unsafe\n"

add a colon after 'mode'.

>@@ -838,24 +852,80 @@

>+    if (!gWatchFile) {
>+      const char* wordList[] = {
>+        "malloc",
>+        "calloc",
>+        "PR_Malloc",
>+        "PR_Calloc",
>+        "ToNewCString",
>+        "ToNewUTF8String",
>+        "ToNewUnicode",
>+        "UTF8ToNewUnicode",
>+        0
>+      };

do we really need this hardcoded list if there is no file? simpler just to
check if the specified file doesn't exist, and bail?

>+    if (NS_FAILED(myWatchList.mTableCPP.Put(NS_LITERAL_CSTRING("new"))))
>+      return -1;

maybe you want to extend this so the c++ functions are in the file too? maybe
with just a newline separating the c and c++ names.

myCfunction1
myCfunction2
...
myCfunction3

myC++function1
myC++function2
...
myC++function3

r=dwitte

Comment 3

[timeless]

checked in