226207 - Internal Server Error while requesting an attachment flag

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Christian Reis]

On CVS HEAD, requesting a flag raises an ISE 500. Problem seems to be a bare
Param() in FlagType.pm, patch coming up.

Question: does the following case in User.pm suffer from the same problem?

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/webtools/bugzilla/Bugzilla&command=DIFF_FRAMESET&file=User.pm&rev2=1.15&rev1=1.14

Comment 1

[Christian Reis]

Attachment: kiko_v1: use &::Param

Comment 2

[Christian Reis]

Attachment: kiko_v2: use Bugzilla::Config

Hixie explained the details on how namespaces and use work, and I guess the
better fix is this one-liner.

Should we clean up other uses of &::Param() ?

Comment 3

[Myk Melez [:myk] [@mykmelez]]

I'm having difficulty reproducing the problem; can you give more specifics about
when it occurs (i.e. requestable or non-requestable flag, attachment or bug, etc.).

Comment 4

[Christian Reis]

It occured in landfill, on caillon's branch (for the xmlflags thing), for
reference -- the log will say. It happens when requesting any attachment flag
when a requestee is specified. I think requesting with no requestee works.

Isn't the code obviously wrong, at any rate? We don't use Bugzilla::Config, so
Param is never placed in our local namespace.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 135922 [details] [diff] [review]
kiko_v2: use Bugzilla::Config

r=myk

Yes, we should fix other instances of &::Param in that script now that it's no
longer necessary.

Comment 6

[Christian Reis]

/cvsroot/mozilla/webtools/bugzilla/Bugzilla/FlagType.pm,v  <--  FlagType.pm
new revision: 1.5; previous revision: 1.4

Thanks.