226238 - 64bit safe code for mozilla/db (WinXP AMD64)

Status: RESOLVED FIXED

(MailNews Core :: Database, enhancement)

Description

[Makoto Kato [:m_kato]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5) Gecko/20031007 Firebird/0.7

Curretly code is defined as pointer type.

 typedef long           mork_ip;  // make sure sizeof(mork_ip) == sizeof(void*)

But WinXP 64bits for AMD64 is that "long" type is defined as 32 bits.  So please
consider this platform.

Reproducible: Always

Steps to Reproduce:
Not need.  This is build issue.

Actual Results:  
Not need.  This is build issue.

Expected Results:  
Not need.  This is build issue.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: mozilla/db diff

Comment 2

[David :Bienvenu]

Comment on attachment 135939 [details] [diff] [review]
mozilla/db diff

r=bienvenu

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Confirming this bug (setting status to NEW) based on David's review.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Makoto, you should now request sr, see http://mozilla.org/hacking/reviewers.html.

Comment 5

[Makoto Kato [:m_kato]]

Attachment: diff at 2004/01/20

Comment 6

[Makoto Kato [:m_kato]]

Old patch isn't simple.  We should replace with PRWord/PRUword, because PRWord
should become void*.  Please see #226094 about PRWord/PRUword's discussion.

Comment 7

[David :Bienvenu]

Comment on attachment 139489 [details] [diff] [review]
diff at 2004/01/20

would you like me to check this in as well?

Comment 8

[Makoto Kato [:m_kato]]

(In reply to comment #7)
> (From update of attachment 139489 [details] [diff] [review])
> would you like me to check this in as well?

I have a permission for check in.  So I checked in.