226241 - Anonymous unions may only contain non-static data members and not define types.

Status: VERIFIED FIXED

(Core :: Networking, enhancement)

Description

[timeless]

http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTest/1069228920.3452.gz
Error (future) 254: "nsProtocolProxyService.h", line 122 # Anonymous unions may 
only contain non-static data members and not define types.
                struct {
                ^^^^^^
Error (future) 254: "nsProtocolProxyService.h", line 127 # Anonymous unions may 
only contain non-static data members and not define types.
                struct {
                ^^^^^^

Comment 1

[Darin Fisher]

bryner: you were working on a patch for this right?

Comment 2

[Darin Fisher]

Attachment: v1 patch

perhaps this will solve the HP-UX build problem.

Comment 3

[Darin Fisher]

fixed-on-trunk

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Trying to compile Mozilla from CVS on Sparc Solaris, I get the following errors.
I suspect that is caused by the checkin for this bug, but I'm not sure.

"nsProtocolProxyService.h", line 133: Error: nsProtocolProxyService::HostInfoIP
is not accessible from nsProtocolProxyService::HostInfo::union.
"nsProtocolProxyService.h", line 134: Error:
nsProtocolProxyService::HostInfoName is not accessible from
nsProtocolProxyService::HostInfo::union.

Comment 5

[Darin Fisher]

doh, because they are defined in the private section of the class.  wonderful! 
patch coming up.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 146216 [details] [diff] [review]
v1 patch

a-, Darin's working on a patch that will keep Solaris happy

Comment 7

[Darin Fisher]

Attachment: solaris bustage fix

Comment 8

[Darin Fisher]

Jens: can you confirm that this patch fixes the problem?  thanks!

Comment 9

[Jens Hatlak (:InvisibleSmiley)]

Confirming. Thanx!

Comment 10

[Roland Mainz]

Comment on attachment 146311 [details] [diff] [review]
solaris bustage fix

Was the pack checked-in yet ?

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 146311 [details] [diff] [review]
solaris bustage fix

r+sr=bzbarsky.	Sigh....

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 146311 [details] [diff] [review]
solaris bustage fix

This would be better solved by doing the standard trick for portably declaring
nested clases:

struct foo;
friend struct foo;
struct foo {
  //...
};

which works around the fact that some compilers implement older versions of the
C++ standard's rules on access and nested classes

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: this should fix the Solaris bustage

Comment 14

[Kyle Yuan]

Comment on attachment 146439 [details] [diff] [review]
this should fix the Solaris bustage

No, it doesn't. The error message is:
""nsProtocolProxyService.h", line 135: Error:
nsProtocolProxyService::HostInfoIP is not accessible from
nsProtocolProxyService::HostInfo::union.
"nsProtocolProxyService.h", line 136: Error:
nsProtocolProxyService::HostInfoName is not accessible from
nsProtocolProxyService::HostInfo::union.
......"

I don't know how to make HostInfo::onion as a friend struct. Maybe we have to
use the previous fix.

Comment 15

[Darin Fisher]

perhaps the union needs to be broken out, named, and then marked up with the
friend decl as dbaron suggested.  or maybe i should just declare the HostInfo
struct at file scope! :-/

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Does it work if you make only the two structs used in the union public?

Comment 17

[Darin Fisher]

> Does it work if you make only the two structs used in the union public?

It should.  Kyle, Jens?

Comment 18

[Kyle Yuan]

(In reply to comment #16)
> Does it work if you make only the two structs used in the union public?

Yes, it works.

Comment 19

[timeless]

Attachment: dbaron's suggestion in comment 16 works on deathstarii (solaris 9/forte7)

Comment 20

[Darin Fisher]

Comment on attachment 146494 [details] [diff] [review]
dbaron's suggestion in comment 16 works on deathstarii (solaris 9/forte7)

sr=darin

patch checked into trunk

Comment 21

[Darin Fisher]

Attachment: 1.7 branch patch

Comment 22

[Darin Fisher]

marking FIXED

Comment 23

[Asa Dotzler [:asa]]

Comment on attachment 146529 [details] [diff] [review]
1.7 branch patch

a=asa (on behalf of drivers) for checkin to 1.7

Comment 24

[Darin Fisher]

fixed1.7

Comment 25

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 204811 has been marked as a duplicate of this bug. ***

Comment 26

[benc]

V.