226462 - Eliminate the aReverseReturnResult argument from nsJSContext::CallEventHandler()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Johnny Stenback (:jst)]

It's silly, and messy, and only one caller cares so the argument should be
eliminated and the mess should be cleaned up. Patch coming up.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Eliminate aReverseReturnResult

Brendan, here's some spiffy XOR logic for you! I hope I got it right :-)

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 136075 [details] [diff] [review]
Eliminate aReverseReturnResult

Isn't this comment backward, because it describes the condition that's the
operand of !, not the condition that the if tests?

+    // if mReturnResult == nsReturnResult_eDoNotReverseReturnResult and
+    // jsBoolResult == true, or if mReturnResult !=
+    // nsReturnResult_eDoNotReverseReturnResult and jsBoolResult ==
+    // false, prevent default

Also, it's awfully "code-like" instead of saying in prose what is going on. 
Maybe "if the handler returned false and its sense is not reversed, or the
handler returned true and its sense is reversed from the usual (false means
cancel), then prevent default."

/be

Comment 3

[Johnny Stenback (:jst)]

Yeah, duh, that comment was backwards. I replaced it with the wording you suggested.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 136075 [details] [diff] [review]
Eliminate aReverseReturnResult

Nifty tricks!  r=caillon with the comment update from brendan.

Comment 5

[Johnny Stenback (:jst)]

Fixed.

Comment 6

[[e-mail]]

x == y is probably more readable than !(x ^ y)

Comment 7

[Boris Zbarsky [:bzbarsky]]

This caused bug 233142