226555 - nsCom.h is missing from gecko-sdk

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Daniel Kouril]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031016
Build Identifier: 

Header nsCom.h is not included in gecko-sdk (every versions since 1.5 inluding
nightly builds) but this header is included by
gecko-sdk/xpcom/include/nsTraceRefcnt.h (which is transitively included from
/tmp/gecko-sdk/xpcom/include/nsCOMPtr.h). Therefore, if I include nsCOMPtr.h in
my code, I got error from a compiler:
g++  -DXPCOM_GLUE -DMOZILLA_STRICT_API -I/tmp/gecko-sdk
-I/tmp/gecko-sdk/xpcom/include -I/tmp/gecko-sdk/nspr/include
-I/tmp/gecko-sdk/string/include -I/tmp/gecko-sdk/necko/include
-I/tmp/gecko-sdk/embedstring/include -I/usr/heimdal/include -I.  -c -o
nsHttpGssapiAuth.o nsHttpGssapiAuth.cpp
In file included from /tmp/gecko-sdk/xpcom/include/nsISupportsImpl.h:52,
                 from /tmp/gecko-sdk/xpcom/include/nsISupportsUtils.h:61,
                 from /tmp/gecko-sdk/xpcom/include/nsCOMPtr.h:64,
                 from nsHttpGssapiAuth.cpp:38:
/tmp/gecko-sdk/xpcom/include/nsTraceRefcnt.h:41: nsCom.h: No such file or directory

Simple 'touch nsCom.h' anywhere in the -Ipath's seems to fix the problem.

Reproducible: Always

Steps to Reproduce:

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

All nsCom.h does now is include nscore.h, so we should probably just change
nsTraceRefcnt.h to just include nscore.h instead.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It would also be good to remove the now-unneeded include of stdio.h.  That could
probably speed up compilation measurably...

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: change all uses of nsCom.h to nscore.h

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 136255 [details] [diff] [review]
change all uses of nsCom.h to nscore.h

could you please add a #warning to nsCom.h stating that it is deprecated.

+#include <stdio.h> // XXXldb We should remove this and add it where needed.

The above comment goes without saying.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 136255 [details] [diff] [review]
change all uses of nsCom.h to nscore.h

a=asa (on behalf of drivers) for checkin to 1.6beta

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Filed bug 227074 about not including stdio.h.

Fix checked in to trunk, 2003-11-29 10:56 -0800.