226617 - document.writing <script> with syntax error stops the first script

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Jesse Ruderman]

Steps to reproduce:

1. Type the following into http://www.squarefree.com/htmledit/ :
<script> alert(5 </script>

Result: syntax error on js console, spinning throbber.
Expected: syntax error on js console.

2. Add a ")".

Result: nothing happens, throbber keeps spinning.
Expected: dialog with "5" in it.


Regression window:
Works: Firebird 11/21
Broken: Firebird 11/22
Broken: Firebird 11/23

I suspect the checkin for bug 224549, "using addEventListener() for keypress
handler prevents JavaScript error propagation".

Comment 1

[Jesse Ruderman]

Assigning to jst (owner of bug 224549), ccing other people from bug 224549

Comment 2

[Asa Dotzler [:asa]]

This sounds like it would be good to fix. Do we know of any high-profile sites
that this impacts? Are users going to be seeing a constantly spinning throbber a
lot?

Comment 3

[Johnny Stenback (:jst)]

Fixing. Not sure how common this is, it looks like it'll be an easy fix.

Comment 4

[Johnny Stenback (:jst)]

Attachment: Only notify XPConnect about exceptions that are actually pending

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 136316 [details] [diff] [review]
Only notify XPConnect about exceptions that are actually pending

Sure, I shoulda thought of that last time!  This should definitely get fixed in
1.6b -- preapproving.

/be

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 136316 [details] [diff] [review]
Only notify XPConnect about exceptions that are actually pending

r=caillon

Comment 7

[Johnny Stenback (:jst)]

Fix checked in.