Closed
Bug 226686
Opened 22 years ago
Closed 22 years ago
The WINNT version of PR_Accept leaks a socket handle if it fails.
Categories
(NSPR :: NSPR, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
4.4.1
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
3.26 KB,
patch
|
darin.moz
:
review+
|
Details | Diff | Splinter Review |
The WINNT version of PR_Accept and PR_AcceptRead creates
a new socket (or gets one from its socket recycle list)
and calls AcceptEx to accept a new connection on the new
socket.
It does not close the socket or put the socket to the
socket recycle list when it fails.
|
Assignee | |
Comment 1•22 years ago
|
||
Close the new socket if PR_Accept or PR_AcceptRead fails.
|
|
Assignee | |
Comment 2•22 years ago
|
||
Patch checked into the NSPR tip (4.5) and
NSPR_4_4_BRANCH (4.4.1).
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.4.1
|
|
Assignee | |
Comment 3•22 years ago
|
||
Comment on attachment 136256 [details] [diff] [review]
Proposed patch
Darin, if you don't have time to review this patch
this week, just cancel the review request. Thanks.
Attachment #136256 -
Flags: review?(darin)
|
||
Comment 4•21 years ago
|
||
Comment on attachment 136256 [details] [diff] [review]
Proposed patch
fwiw, r=darin
Attachment #136256 -
Flags: review?(darin) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•