Closed Bug 226870 Opened 21 years ago Closed 21 years ago

FMR in outer table frame

Categories

(Core :: Layout: Tables, defect)

Product:
Core
Component:
Layout: Tables
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bernd_mozilla, Assigned: bernd_mozilla)

Details

Attachments

(1 file)

patch
3.32 KB, patch
dbaron
: review+
dbaron
: superreview+
tor
: approval1.6b+
Details | Diff | Splinter Review
see: http://bugzilla.mozilla.org/show_bug.cgi?id=217527#c17 I guess I need to copy the old overflow area and should not use it twice.
Attached patch patch — — Splinter Review
tor could you please try the patch at slashdot.org
No FMR, but some assertions I didn't see before: ###!!! ASSERTION: this doesn't do anything: 'NS_UNCONSTRAINEDSIZE != aReflowStat e.availableWidth', file c:/home/build/layout/html/table/src/../../../../../mozil la/layout/html/table/src/nsTableFrame.cpp, line 1976 ###!!! ASSERTION: this doesn't do anything: 'NS_UNCONSTRAINEDSIZE != aReflowStat e.availableWidth', file c:/home/build/layout/html/table/src/../../../../../mozil la/layout/html/table/src/nsTableFrame.cpp, line 1976 ###!!! ASSERTION: this doesn't do anything: 'NS_UNCONSTRAINEDSIZE != aReflowStat e.availableWidth', file c:/home/build/layout/html/table/src/../../../../../mozil la/layout/html/table/src/nsTableFrame.cpp, line 1976 ###!!! ASSERTION: this doesn't do anything: 'NS_UNCONSTRAINEDSIZE != aReflowStat e.availableWidth', file c:/home/build/layout/html/table/src/../../../../../mozil la/layout/html/table/src/nsTableFrame.cpp, line 1976 ###!!! ASSERTION: this doesn't do anything: 'NS_UNCONSTRAINEDSIZE != aReflowStat e.availableWidth', file c:/home/build/layout/html/table/src/../../../../../mozil la/layout/html/table/src/nsTableFrame.cpp, line 1976
Comment on attachment 136420 [details] [diff] [review] patch David, yes I have that other bug 219141 . But I would like to play save here as I dont have yet a reviewable patch for the other bug.
Attachment #136420 - Flags: superreview?(dbaron)
Attachment #136420 - Flags: review?(dbaron)
Comment on attachment 136420 [details] [diff] [review] patch It would be nice to find a simpler solution, but r+sr=dbaron.
Attachment #136420 - Flags: superreview?(dbaron)
Attachment #136420 - Flags: superreview+
Attachment #136420 - Flags: review?(dbaron)
Attachment #136420 - Flags: review+
Comment on attachment 136420 [details] [diff] [review] patch I believe this patch is low risk and avoids a freed memory read (aka apossible crash)
Attachment #136420 - Flags: approval1.6b?
Comment on attachment 136420 [details] [diff] [review] patch a=tor for 1.6b.
Attachment #136420 - Flags: approval1.6b? → approval1.6b+
fix checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: