226919 - SendStatusChange should check for NS_ERROR_FILE_TARGET_DOES_NOT_EXIST

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

NS_ERROR_FILE_TARGET_DOES_NOT_EXIST  should probably be treated like
NS_ERROR_FILE_NOT_FOUND

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 136407 [details] [diff] [review]
patch

r=bzbarsky.  Seems reasonable.

Comment 3

[Darin Fisher]

is there a use case where this patch makes a difference?

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 136407 [details] [diff] [review]
patch

this fixes a wrong error message if a helper app is not found. very low risk,
just changes what error message is displayed (a useful one instead of a general
one)

darin: there is. caillon experienced it - he configured a helper app for some
mime type, but it no longer existed, and this error is what this code saw.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 136407 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.6beta

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <-- 
nsExternalHelperAppService.cpp
new revision: 1.233; previous revision: 1.232
done