Closed
Bug 227029
Opened 21 years ago
Closed 21 years ago
nsExternalAppHandler dynamically allocates buffer for no reason
Categories
(Core Graveyard :: File Handling, defect)
Core Graveyard
File Handling
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file)
|
3.15 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
constructor:
1028 mDataBuffer = (char *) nsMemory::Alloc((sizeof(char) * DATA_BUFFER_SIZE));
destructor:
1037 if (mDataBuffer)
1038 nsMemory::Free(mDataBuffer);
no reallocations in between.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #136470 -
Flags: superreview?(bz-vacation)
Attachment #136470 -
Flags: review?(bz-vacation)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•21 years ago
|
||
Comment on attachment 136470 [details] [diff] [review]
patch
Yeah, makes sense. r+sr=bzbarsky
Attachment #136470 -
Flags: superreview?(bz-vacation)
Attachment #136470 -
Flags: superreview+
Attachment #136470 -
Flags: review?(bz-vacation)
Attachment #136470 -
Flags: review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Checking in nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v <--
nsExternalHelperAppService.cpp
new revision: 1.235; previous revision: 1.234
done
Checking in nsExternalHelperAppService.h;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.h,v <--
nsExternalHelperAppService.h
new revision: 1.54; previous revision: 1.53
done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•