227053 - gHistoryStatus has no properties

Status: RESOLVED FIXED

(Core Graveyard :: History: Global, defect)

Description

[HJ]

Steps to reproduce (100%):
a)open the history panel in the sidebar
b)click on a container
c)use arrow down/up keys

Current result:
Error: gHistoryStatus has no properties
Source File: chrome://communicator/content/history/history.js
Line: 164

Expected result: no error

Note: 'gHistoryStatus' is not initialized (null) in the sidebar so there should
a) add a check or b) initiazlize 'gHistoryStatus' with the browser window status
bar.

It's a sidebar panel issue, but history specific, so that's why I selected
"History: Global" as component (hope it's the right component).

Comment 1

[timeless]

Attachment: handle null gHistoryStatus

Comment 2

[[e-mail]]

Attachment: Fix several issues

Building on attachment 137645 [details] [diff] [review], I spotted three further errors:
1. I had switched a test so that delete by host/domain stopped working :-(
2. Expand/Collapse context menus didn't work
3. Closing the history sidebar didn't unload the pref observer

Comment 3

[Andreas Kunz]

I did not read the patches in detail, so I'll just ask:
Did you consider
http://lxr.mozilla.org/seamonkey/source/xpfe/components/history/resources/history.js#127
? It determines if it's run in the sidebar or in its own window based on if
gHistoryStatus is defined...

Comment 4

[timeless]

Comment on attachment 137680 [details] [diff] [review]
Fix several issues

this is not ipv6 safe...

Comment 5

[[e-mail]]

Attachment: Updated for irc comments

Comment 6

[[e-mail]]

Attachment: Tested :-)

Comment 7

[Alec Flett]

Comment on attachment 138700 [details] [diff] [review]
Tested :-)

sr=alecf

Comment 8

[[e-mail]]

Fix checked in.

Comment 9

[Andreas Kunz]

Neil, with a build that has your patch I get quite often an exception I never
saw before:
Error: [Exception... "Component returned failure code: 0x80070057
(NS_ERROR_ILLEGAL_VALUE) [nsITreeView.getCellText]"  nsresult: "0x80070057
(NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://communicator/content/history/history.js :: historyOnSelect :: line 157"
 data: no]
Source File: chrome://communicator/content/history/history.js
Line: 157

E.g. when in "group by none" mode and deleting an entry using the context menu
or the "Edit" menu. Venkman says that currentIndex is -1 when this happens.
Switching group mode gives a similar error, also with reference to this line.

Comment 10

[[e-mail]]

Attachment: Fix -1 issue

Hmmm... did the status bar actually work before?

Comment 11

[[e-mail]]

Comment on attachment 139013 [details] [diff] [review]
Fix -1 issue

OK, so by switching the tests around a bit I can make rowIsContainer true for a
-1 index so it doesn't query for the URL.

Comment 12

[Alec Flett]

Comment on attachment 139013 [details] [diff] [review]
Fix -1 issue

sr=alecf

Comment 13

[[e-mail]]

Fix checked in.