227093 - Close/exit confirmation when connected to servers/networks

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Description

[James Ross]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031128 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031128 Firebird/0.7+

When you try to close Chatzilla, when connected to servers, it just closes
without any confirmation.

Reproducible: Always

Steps to Reproduce:
1. Connect to a server.
2. Click the [x] or whatever's appropriate for your window manager.
Actual Results:  
Chatzilla disconnected and closed.

Expected Results:  
Chatzilla should have asked first.

This is as much a reminder for me as anything else, since it's been reported at
least twice recently on irc://moznet/chatzilla.

Comment 1

[Felix Miata]

Looks an awful lot like bug 39057.

Comment 2

[Oriyan Hermoni]

Although this works even when not connected to a server and/or channel, it's
good enough.
Save this as a plugin (thanks to Silver/James Ross for showing me):
window.onClose = function onClose() {
if ("userClose" in client && client.userClose) {
return true;
}
if (!confirm("Are you sure you wish to quit ChatZilla? WARNING: Pressing Yes
will close the window and will disconnect from the servers and channels"))
return false;
client.userClose = true;
display(MSG_CLOSING);
if (!("getConnectionCount" in client) ||
client.getConnectionCount() == 0) {
return true;
}
client.quit(client.userAgent);
return false;
}

Comment 3

[:Gavin Sharp [email: [e-mail]]]

*** Bug 283854 has been marked as a duplicate of this bug. ***

Comment 4

[Oriyan Hermoni]

Attachment: Adds a confirmation dialog

This patch adds a confirmation dialog when connected to a server.

Comment 5

[Oriyan Hermoni]

Attachment: Adds quit confirmation dialog

Small change from previous patch. Changes confirm to confirmEx.

Comment 6

[:Gijs (he/him)]

(In reply to comment #5)
> Created an attachment (id=175724) [edit]
> Adds quit confirmation dialog
> 
> Small change from previous patch. Changes confirm to confirmEx.

Is there any chance of having a preference + checkbox for this confirmation
dialog, similar to what Suite and Firefox do when you have multiple tabs open?
confirmEx supports that :-). I can imagine some people won't like the dialog
showing up every time.

Comment 7

[Samuel Sieb]

Comment on attachment 175724 [details] [diff] [review]
Adds quit confirmation dialog

I agree, it definitely needs to be able to be disabled.

Comment 8

[Oriyan Hermoni]

Attachment: Fixes previous patch and adds a pref to turn it off.

Comment 9

[Oriyan Hermoni]

Attachment: Change to previous patch

Replaces:
var checkState = { value: client.prefs["warnOnClose"] };
With:
var checkState = { value: true };

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 177394 [details] [diff] [review]
Change to previous patch

a=asa

Comment 11

[James Ross]

Checked in --> FIXED.

Automated builds at http://twpol.dyndns.org/mozilla/chatzilla/nightly/ will
include this shortly.