Closed Bug 227107 Opened 21 years ago Closed 21 years ago

Help button in Offline & Disk Space preferences is broken

Categories

(SeaMonkey :: Help Documentation, defect)

Product:
SeaMonkey
Component:
Help Documentation
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: u60234, Assigned: u60234)

Details

Attachments

(1 file, 1 obsolete file)

With Neil's nit
2.08 KB, patch
neil
: review+
alecf
: superreview+
asa
: approval1.6b+
Details | Diff | Splinter Review 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031128

Clicking the Help button in the Offline & Disk Space preferences panel does not
take you to the relevant help section, instead it displays the "Welcome to
Mozilla Help" screen. It appears that when the offline prefs panel where moved
to mail & news in bug 127423, the pref-help.js file was never updated with the
new location.

Steps to reproduce:
Go to Edit -> Preferences -> Mail & Newsgroups -> Offline & Disk Space, and
click on the Help button.

Actual result:
You will see "Welcome to Mozilla Help"

Expected result:
To see help regarding offline preferences.
Attached patch patch (obsolete) — — Splinter Review 

    
    

    
  
Comment on attachment 136543 [details] [diff] [review]
patch

Let's have Neil review this, since it's out of my module.

        Attachment #136543 -
        Flags: review?(neil.parkwaycc.co.uk)

    
    

    
  
Comment on attachment 136543 [details] [diff] [review]
patch

This is such a wrong way to implement the help button... sigh...

Nit: you should also change the text in the help itself; before:
1. Open the Edit menu and choose Preferences.
2. Click Offline & Disk Space.
After:
2. Under the Mail & Newsgroups category, select Offline & Disk Space. (etc.)

        Attachment #136543 -
        Flags: review?(neil.parkwaycc.co.uk) → review+

    
  

        Attachment #136543 -
        Flags: approval1.6b?

    
  

        Attachment #136543 -
        Flags: approval1.6b? → superreview?(alecf)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        With Neil's nit
        — 
          — Splinter Review
      

    


  

        Attachment #136543 -
        Attachment is obsolete: true

    
  

        Attachment #136662 -
        Flags: superreview?(alecf)

        Attachment #136662 -
        Flags: review?(neil.parkwaycc.co.uk)

    
  

        Attachment #136543 -
        Flags: superreview?(alecf)

    
    

    
  
Comment on attachment 136662 [details] [diff] [review]
With Neil's nit

rj, I assume you're OK with this help text fix?

        Attachment #136662 -
        Flags: review?(neil.parkwaycc.co.uk) → review+

    
    

    
  
Comment on attachment 136662 [details] [diff] [review]
With Neil's nit

sr=alecf

        Attachment #136662 -
        Flags: superreview?(alecf) → superreview+

    
    

    
  
Comment on attachment 136662 [details] [diff] [review]
With Neil's nit

yes, r=rlk@trfenv.com on the help text fix.

        Attachment #136662 -
        Flags: approval1.6b?

    
    

    
  
Comment on attachment 136662 [details] [diff] [review]
With Neil's nit

a=asa (on behalf of drivers) for checkin to 1.6beta

        Attachment #136662 -
        Flags: approval1.6b? → approval1.6b+

    
    

    
  
--> hasse
Assignee: rlk → jasajudeju
Summary: Help button in Offline & Disk Space preferences is broken → Help button in Offline & Disk Space preferences is broken

    
    

    
  
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED

    
  
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: