227107 - Help button in Offline & Disk Space preferences is broken

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[u60234]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031128

Clicking the Help button in the Offline & Disk Space preferences panel does not
take you to the relevant help section, instead it displays the "Welcome to
Mozilla Help" screen. It appears that when the offline prefs panel where moved
to mail & news in bug 127423, the pref-help.js file was never updated with the
new location.

Steps to reproduce:
Go to Edit -> Preferences -> Mail & Newsgroups -> Offline & Disk Space, and
click on the Help button.

Actual result:
You will see "Welcome to Mozilla Help"

Expected result:
To see help regarding offline preferences.

Comment 1

[u60234]

Attachment: patch

Comment 2

[R.J. Keller]

Comment on attachment 136543 [details] [diff] [review]
patch

Let's have Neil review this, since it's out of my module.

Comment 3

[[e-mail]]

Comment on attachment 136543 [details] [diff] [review]
patch

This is such a wrong way to implement the help button... sigh...

Nit: you should also change the text in the help itself; before:
1. Open the Edit menu and choose Preferences.
2. Click Offline & Disk Space.
After:
2. Under the Mail & Newsgroups category, select Offline & Disk Space. (etc.)

Comment 4

[u60234]

Attachment: With Neil's nit

Comment 5

[[e-mail]]

Comment on attachment 136662 [details] [diff] [review]
With Neil's nit

rj, I assume you're OK with this help text fix?

Comment 6

[Alec Flett]

Comment on attachment 136662 [details] [diff] [review]
With Neil's nit

sr=alecf

Comment 7

[R.J. Keller]

Comment on attachment 136662 [details] [diff] [review]
With Neil's nit

yes, r=[e-mail] on the help text fix.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 136662 [details] [diff] [review]
With Neil's nit

a=asa (on behalf of drivers) for checkin to 1.6beta

Comment 9

[R.J. Keller]

--> hasse

Comment 10

[R.J. Keller]

Fix checked in.