227183 - Download Manager doesn't close after a download has finished

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect, P3)

Description

[Haris Karahristianidis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031130 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031130 Firebird/0.7+

I have checked the option to close after all downloads finish, but this doesn't
happen with pdf files.

Reproducible: Always

Steps to Reproduce:
1.Click on a pdf link
2.
3.

Actual Results:  
The Download Manager remains open

Expected Results:  
It should close

Comment 1

[Vlad Dascalu]

*** Bug 227185 has been marked as a duplicate of this bug. ***

Comment 2

[Sean Kent]

For that matter, the DL Mgr doesn't close after downloading any file.  Using
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031201
Firebird/0.7+

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Does the appearance of the download item change from that of showing a progress
bar to that of showing "Done" after the download manager finishes downloading
the file? 

Can you provide some links that exhibit this behavior?

Comment 4

[James [silentj]]

yes the downloads do appear as 'done' no problem at at all

this happens with anything that you download

http://ftp.mozilla.org/pub/firebird/nightly/latest-trunk

try it with any of the nightlys

Comment 5

[Steffen Wilberg]

Ben, I guess you meant to take this bug before assigning it?
->Ben

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Um... can you re-check your preferences... I changed the download pref names on
the day before 11/30 and settings that you may have had on the previous day will
no longer be in effect. As it stands, this worksforme in new profiles. 

Comment 7

[Steffen Wilberg]

Attachment: patch: use the correct pref

This line in downloads.js throws an exception:
    var autoClose = pref.getBoolPref(PREF_BDM_CLOSEWHENDONE)
It works if you catch that exception. The reason is that
PREF_BDM_CLOSEWHENDONE is defined as "browser.download.closeWhenDone".
But the correct pref is "browser.download.manager.closeWhenDone".

Comment 8

[Vlad Dascalu]

Reassigning QA Contact to default.

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 136741 [details] [diff] [review]
patch: use the correct pref

Oh, nice catch Steffen! I'll check this in right away.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Patch checked in. I'll mark the bug fixed for you.