227263 - trying to get domain from document when URL is about:blank produces "uncaught exception"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Henrik Gemal]

My right click extension checks the domain of the current window. but if the
user right clicks on a about:blank page I get the following exception:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIDOMNSHTMLDocument.domain]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://tdccms/content/context.js :: anonymous :: line 60"  data: no]

the line is:
if ("domain" in document.commandDispatcher.focusedWindow.document &&
document.commandDispatcher.focusedWindow.document.domain)

is it correct to do an exception?

Comment 1

[Johnny Stenback (:jst)]

Attachment: Fix.

This makes document.domain null for documents that don't come from a domain.

Comment 2

[Johnny Stenback (:jst)]

Fixed.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Checked in a test for this, called test_bug196523.html