227406 - WIN32_MODULE_DESCRIPTION should be Mozilla Firebird, not Next Generation Browser...

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Asa Dotzler [:asa]]

In the "MozillaFirebird.exe Properties" window, "Version" tab, the "Product
Version" has the value: "1.6b: 2003120308" and the "File Version" (visible in
same dialog as well as the tooltip for the executable) is listed as 0.0.0.0 when
it should be listed as 0.7+ (or if the periods are required, then something like
0.7.0.0, though it appears there might be a "short file version" and a "long
file version available to us if we want to use it).  Also, in the "General"
dialog, the "Description" should probably be "Mozilla Firebird" (microsoft
consistently uses the "Microsoft <application name>" value for that field. 

I also noticed that in the Uninstall listing, the version value has an
extraneous "." at the end

Comment 1

[Ali Ebrahim]

*** Bug 227408 has been marked as a duplicate of this bug. ***

Comment 2

[Jesse Ruderman]

From bug 227408: Kerio Personal Firewall displays WIN32_MODULE_DESCRIPTION as if
it is the name of the program.

From http://forums.mozillazine.org/viewtopic.php?t=38423: Sygate's applications
listing does the same.

So WIN32_MODULE_DESCRIPTION should probably just be "Mozilla Firebird".

Comment 3

[Steffen Wilberg]

That was Ben:
http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=12%2F02%2F2003+23%3A07&maxdate=12%2F02%2F2003+23%3A10

Comment 4

[Bill Mason]

*** Bug 227572 has been marked as a duplicate of this bug. ***

Comment 5

[Ali Ebrahim]

Attachment: Set WIN32_MODULE_DESCRIPTION=Mozilla Firebird

The patch sets WIN32_MODULE_DESCRIPTION=Mozilla Firebird

The "Next Generation...." string was showing up in all sorts of inappropriate
places (such as Open with, firewall settings, etc). Setting it to Mozilla
Firebird makes a lot more sense as people can then actually identify it.

This is actually a major branding issue.

Comment 6

[Ali Ebrahim]

Comment on attachment 136914 [details] [diff] [review]
Set WIN32_MODULE_DESCRIPTION=Mozilla Firebird

Requesting review from [e-mail]

Comment 7

[Bill Gianopoulos [:WG9s]]

So then shouldn't we set:

WIN32_MODULE_DESCRIPTION=Mozilla Firebird-The Next Generation browser for
Microsoft Windows.

Comment 8

[Bill Gianopoulos [:WG9s]]

Hmm.  Ok looking at how other windows applications do this (including Microsoft
ones) this appears to be poor naming of these attributes on Microsoft's part. 
Product name appears to be used to have the product name (at least that part
makes sense).  Module description appears to be the name of the individual
product component (or just the same as product name if the product does not have
individual components)  So for Microsfot Word (for example) The product is
Microsoft Office and the module descritpion is Microsoft Word.  So I guess by
convention the module description should just be Mozilla Firebird so we should
just go with the currently proposed patch.

One additional suggestion though.  Would it be possible to make the version be
0,7,yyyy,mmdd instead of 0,7,0,0?  This would make it easier to differentiate
between nightlies.

Comment 9

[Ali Ebrahim]

No, that's far too long a string to be appearing all over Windows, and I'm sure
it's against Windows UI guidelines.

For example, in places where we see strings such as  "Internet Explorer",
"Microsoft Word", and "Wordpad", we want to have "Mozilla Firebird", not
"Mozilla Firebird-The Next Generation browser for Microsoft Windows."

And when I say all over Windows I really mean it. Firewall settings, right click
context menus for "Open with...", etc etc.

One of our goals here is proper integration and behaviour as a well-behaved
Windows application. So we should therefore follow what is the established
convention for WIN32_MODULE_DESCRIPTION and not set it to something else. In
short, WIN32_MODULE_DESCRIPTION is the place for the application name, not for
descriptive text (yes, I realise that it's therefore a poorly named field, but
we don't control this).

Comment 10

[Ali Ebrahim]

> One additional suggestion though.  Would it be possible to make the version be
0,7,yyyy,mmdd instead of 0,7,0,0?  This would make it easier to differentiate
between nightlies.

This is a separate issue from whats being reported here and therefore should
probably have its own bug. The version string issue has already been addressed
and fixed in bug 227353 and right now it displays as 0.7.0.0 in Windows (or at
least will be in new nightlies that are produced as of 2003-12-06).

Comment 11

[Brian Ryner (not reading)]

checked in.

Comment 12

[Faxmaster]

Sygate Firewall now reads "Mozilla Firebird" again on 20031207.

Comment 13

[:deanis74]

verified based on above comment

Comment 14

[Bill Mason]

*** Bug 227747 has been marked as a duplicate of this bug. ***