227711 - wrong mime type shown when helper app entry present

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

1. create a text/plain helper app entry, extension .txt, check "always ask"
2. load http://www.hixie.ch/tests/adhoc/http/content-type/001.txt (real type is
application/x-hixie-test)
3. be surprised as you get told the type is text/plain

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 136978 [details] [diff] [review]
patch

Doh.  r=bzbarsky

Comment 3

[Darin Fisher]

Comment on attachment 136978 [details] [diff] [review]
patch

>Index: nsExternalHelperAppService.cpp

>+    LOG(("Extension '%s' matches mime info: %s\n", aFileExt, matches ? "yes" : "no"));

i still think this kind of logging is extraneous, especially since this
is compiled into release builds.

sr=darin

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 136978 [details] [diff] [review]
patch

this fixes a problem that a wrong mime type is being displayed, and (related)
that "never ask again" does not work. it should be a pretty safe patch.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 136978 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to Mozilla 1.6

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <-- 
nsExternalHelperAppService.cpp
new revision: 1.234; previous revision: 1.233
done