Closed Bug 227758 Opened 21 years ago Closed 21 years ago

Fix scriptability of some nsIScriptSecurityManager.idl methods

Categories

(Core :: Security: CAPS, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla1.7alpha

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

I want to be able to call securityCompareURIs (from chrome) and possibly
checkSameOriginURI; btw subjectPrincipalIsSystem() seems useless.
Attached patch Proposed patchSplinter Review
[expletive deleted] caillon wouldn't let me script securityCompareURIs :-(
Attachment #137018 - Flags: superreview?(darin)
Attachment #137018 - Flags: review?(caillon)
Comment on attachment 137018 [details] [diff] [review]
Proposed patch

The changes here (especially the first hunk of the patch) look good.  r=me.
Attachment #137018 - Flags: review?(caillon) → review+
OS: AIX → All
Comment on attachment 137018 [details] [diff] [review]
Proposed patch

Why not script securityCompareURI? checkSameOriginURI is just a wrapper around
it, and returning a boolean is easier to deal with in script.

sr=dveditz
Attachment #137018 - Flags: superreview?(darin) → superreview+
Because everything else in caps throws on deny.  Whether that should continue to
be the case can be debated, but not here.
Mine :-)
Assignee: security-bugs → neil.parkwaycc.co.uk
Target Milestone: --- → mozilla1.7alpha
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Ah, the other issue with checkSameOriginURI is that it dumps all sorts of
nasty-looking warnings to the console when it fails :-(
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: