227819 - [FIXr]left and right results in wrong width with box-sizing border-box

Status: RESOLVED FIXED

(Core :: Layout: Positioned, defect, P2)

Description

[Erik Arvidsson]

When both left and right are supplied the width of the element stretches. Hover
when the box sizing is not set to content-box the width is incorrect. This is
most likely because the box sizing property is incorrectly ignored in this case.

Comment 1

[Erik Arvidsson]

Attachment: A div with both left and right inside another div

No red should be seen at any time

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix (diff -u)

Actually, the problem is that the box-sizing property is _applied_ in this case
(to widths/heights that already subtract off the paddings/borders in their
computation).  It should not be.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix (diff -uw)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 137067 [details] [diff] [review]
Fix (diff -uw)

David, would you review?  The CSSParser changes were prompted by some of the
(unjustified, without those changes, hence commented out) layout assertions...
and happen to fix a CSS-compliance bug as far as I can tell.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Taking.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Checked in for 1.7a.

Comment 7

[Philip K. Warren]

Since this checkin, I am getting the following assertion several hundred times
when running the editor:

###!!! ASSERTION: Negative Width Input - very bad: 'mComputedWidth >= 0', file
/home/pkw/sb/mozilla/trunk/mozilla/layout/html/base/src/nsHTMLReflowState.cpp,
line 2532
Break: at file
/home/pkw/sb/mozilla/trunk/mozilla/layout/html/base/src/nsHTMLReflowState.cpp,
line 2532

Comment 8

[Boris Zbarsky [:bzbarsky]]

Philip, would you mind filing a separate bug on me on that assert?  I'll have to
debug to see what's up....

Comment 9

[Philip K. Warren]

Filed Bug 230249 for the assertion.

Comment 10

[Brian Earley]

Fix causes a new bug 232754.