227958 - big5, gb2312 and ksc5601.1987-0 fonts are not listed in the font selection menu

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Wily Yuen]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6b) Gecko/20031208
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6b) Gecko/20031208

This is GTK1 X11core version of Mozilla running under Linux.


With Mozilla 1.6 beta I downloaded just an hour ago, I found that when I went to:

Edit > Preferences > Fonts

When I try to adjust the font configuration for Simplified Chinese or
Traditional Chinese (Taiwan), the font selection items are gone and no -big5-0
or -gb2312.*-0 font can be found by Mozilla 1.6 Beta. This problem does NOT
exist in Mozilla 1.5 or 1.6 Alpha.

Curiously Traditional Chinese (Hong Kong) with encoding -big5hkscs-0, is NOT
affected.

Reproducible: Always

Steps to Reproduce:
1.Make sure your system has big5 and gb2312 fonts installed
2.Edit > Preferences > Fonts
3.Try to configure the setting for Traditional Chinese (Taiwan) or Simplified
Chinese, and you will find the settings are all blank: fonts with such encoding
is NOT detected.
Actual Results:  
The font sections for big5 / gb2312.* are blank.

Expected Results:  
There are fonts for big5 / gb2312 encoding installed in the system. And they
should show up in the font section by default.

Comment 1

[Wily Yuen]

Attachment: Font selection missing screenshot

This is a screenshot of the description in comment #1.

Note that this bug does not apply to Traditional Chinese (Hong Kong)/
-big5hkscs-0 encoding fonts.

Comment 2

[Jungshik Shin]

I confirmed it in 1.6b. It regressed between 2003-11-08-06 and 2003-11-09-08.


http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?
treeid=default&module=all&branch=&branchtype=match&dir=&file=&filetype=match&who
=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=11%2F08%2F2003+00%
3A00%3A01&maxdate=2003-11-10+00%3A00%3A01&cvsroot=%2Fcvsroot

A couple of  checkins by me (bug 221024 and bug 221666) could be related, but I 
can't quite see how they can lead to a regression like this.

For zh-CN, gb18030.2000-0 and gbk-0 fonts are listed. For ko, ksc5601.1992-3 and 
johab* fonts are listed, but ksc5601.1987-0 fonts are not. 

This is a rather serious bug so that I think it's a blocker for 1.6

Comment 3

[Jungshik Shin]

I guess my check-in for bug 225106 [1] is more likely to be the cause than other 
two mentioned in the last comment.


http://tinderbox.mozilla.org/bonsai/cvsview2.cgi?
diff_mode=context&whitespace_mode=show&subdir=mozilla/intl/uconv/src&command=DIF
F_FRAMESET&file=nsCharsetConverterManager.cpp&rev1=1.102&rev2=1.
103&root=/cvsroot

Just in case, I'm adding rbs to CC.

Comment 4

[Jungshik Shin]

Attachment: a patch

By adding three 'charset' names (gb_2312-80, ks_c_5601-1987, x-x-big5) to
charsetData.properties file, we can fix this bug. As noted in the patch, they
along with about a dozen other entries can be removed once bug 215537 is fixed
(smontau, would you review the patch there?)

Besides, they had better be renamed as 'gb2312gl', 'ksc5601gl', and
'big5noascii' in intl/uconv/* (as they are, their names don't clearly indicate
that they're encoders for character sets invoked on GL or non-ASCII part of
Big5).	There was a patch made a few years ago to do that, but it didn't get
landed because somehow ftang didn't like it.  Alternative is to just use
X11 registry-encoding pairs (gb2312.1980-0, ksc5601.1987-0, big5-0)

Comment 5

[Jungshik Shin]

Comment on attachment 137183 [details] [diff] [review]
a patch

Asking for r/sr.

'zh' in the following should be 'zh-CN':
gb_2312-80.LangGroup		   = zh

Comment 6

[Simon Montagu :smontagu]

Comment on attachment 137183 [details] [diff] [review]
a patch

r=smontagu

Comment 7

[Jungshik Shin]

setting the target milestone.
rbs, can you sr? it's a trivial fix, but the symptom is rather serious.

Comment 8

[rbs]

Comment on attachment 137183 [details] [diff] [review]
a patch

sr=rbs

Traditional Chinese(Taiwan)
		  ^^^ missing space. Not aesthetically pleasant.

Comment 9

[Jungshik Shin]

Comment on attachment 137183 [details] [diff] [review]
a patch

Thanks for r/sr.
Asking for a1.6.

Affected platform : Linux and all Unix-like OS 
Users : CJK users and anyone who view CJK pages
Risk : low
Symptom: serious because X11 fonts for CJK in widely used X11 font encodings
are not listed at all 
in the font selection menu. This is a MUST-fix for 1.6


P.S. If drives don't mind, I want to insert a space between 'Traditional' and
'(Hong Kong) / (Taiwan)' at

http://lxr.mozilla.org/seamonkey/source/xpfe/components/prefwindow/resources/lo
cale/en-US/pref-fonts.dtd#32

when landing this patch.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 137183 [details] [diff] [review]
a patch

a=asa (on behalf of drivers) for checkin to Mozilla 1.6

Comment 11

[Jungshik Shin]

fix checked in. thanks.