227991 - nsNSSCertificateDB::AddCertFromBase64 crashes

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[David :Bienvenu]

nsNSSCertificateDB::AddCertFromBase64 crashes because of a call to
CERT_DestroyCertificate that destroys a cert that's been cleaned up with
CERTCertificateCleaner. Patch upcoming

Comment 1

[David :Bienvenu]

My bad - I didn't test my new patch correctly after I was advised to add this
call to CERT_DestroyCertificate :-( I didn't clean out my cert db, I guess, so I
didn't hit this code again.

this is fallout from bug 221329 - the bug won't affect any existing
clients/users because this is a new interface but I do need to fix this the new
user of this interface.

Comment 2

[David :Bienvenu]

Attachment: proposed fix

just remove the call to CERT_DestroyCertificate

Comment 3

[Kai Engert (:KaiE:)]

Comment on attachment 137163 [details] [diff] [review]
proposed fix

r=kaie
thanks!

Comment 4

[David :Bienvenu]

Kaie, can you check this in for me once Scott gives his sr? I don't think I can
check into the security directory (can't remember if that was a problem before
or not).

Comment 5

[Kai Engert (:KaiE:)]

David, to my knowledge the additional restrictions on security/manager/ have
been dropped over a year ago - your account should be fine to check it in.

But if you experience problems or prefer me to do it, I'm glad to help.

Comment 6

[David :Bienvenu]

fix checked in, a=sspitzer over aim.