228259 - Downloading creates a directory with the same name as downloaded file

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Frederic Bezies]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031212 Firebird/0.7+ (MozJF)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031212 Firebird/0.7+ (MozJF)

Seems to be a recent regression (2 days ?).

It is simple to see. Grab latest nightly of firebird (11 december for now), go
to this url, and download mozilla.exe full installer.

You will get this :

your target/mozilla-win32-1.5-installer.exe/mozilla-win32-1.5-installer.exe

Really annoying.

I saw this bug on a recent homemade build (based on sources up-to-date at
midnight mozilla.org/time)

Reproducible: Always

Steps to Reproduce:
1.grab 11 december build
2.go to url
3.download installer.exe

Actual Results:  
Directory with same file name.

Expected Results:  
no directory.

Happens only with .exe file.

COuld it be related to bugfix for 214260 added on 10th december ?

Comment 1

[Mike Pesce (:By-Tor)]

Happens on all file types for me, not exclusively .exe files.

Comment 2

[Frederic Bezies]

More infos from thread in mozillazine
(http://forums.mozillazine.org/viewtopic.php?t=4035)

Mamokatte said there is kinda workaround :

[Mamokatte on] 
Okay, I have it narrowed down. If you have it set to automatically save to disk
for a filetype, left-clicking on the file will automatically save the file to
disk properly. But if you're prompted for what to do with the file, and select
"Save to Disk", it creates the extra folder. It does this for me for all
filetypes not automatically handled by Firebird.

Right-clicking on a file and selecting "Save Link to Disk" never exhibits the
problem.
[Mamokatte off]

Comment 3

[Nitin (vfwlkr)]

That thread would be:
http://forums.mozillazine.org/viewtopic.php?t=40358

Comment 4

[Frederic Bezies]

Yes. I made a mistake while copy / pasting link :[

Anyway, it might be useful ?!

Comment 5

[PikeUK]

The leafname is appended once here:

http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/downloads/content/nsHelperAppDlg.js.in#736

Then again here:

http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/downloads/content/nsHelperAppDlg.js.in#254

Removing line 736 seems to fix the problem.

The only wierd thing is that this checkin (from bug 227282) was made on
2003-12-06 but didn't cause problems until 2003-12-11. However Ben changed some
Makefiles on the 11th so maybe he originally checked the fix in to an unbuilt
version of the file (there appear to be several versions listed on lxr) then
brought the file in to the build on the 11th?  I downloaded a build from
2003-12-09 and it had a completely different version of nsHelperAppDlg.js (which
didn't have a validateLeafName method and thus didn't have this error).

Comment 6

[Jeff Walden [:Waldo]]

*** Bug 228382 has been marked as a duplicate of this bug. ***

Comment 7

[Bill Gianopoulos [:WG9s]]

Attachment: pike's patch

I created a patch with pike's suggested fix after testing it in my own build.

Comment 8

[PikeUK]

There are two nsHelperAppDlg.js.in files in my tree, the other is at
mozilla/toolkit/mozapps/downloads/src/nsHelperAppDlg.js.in does that need to be
updated as well, there's also a nsHelperAppDlg.js but I assume that version is
no longer built since it doesn't appear to even have a validateLeafName method
(it looks like the one from the 2003-12-09 build I downloaded)?

(Sorry if this is all irrelevant, I'm not a real programmer, the build process
is like some sort of magical incantation to me).

Comment 9

[Chris Neale]

mozilla/toolkit/mozapps/downloads/src/nsHelperAppDlg.js is created from
mozilla/toolkit/mozapps/downloads/src/nsHelperAppDlg.js.in

Comment 10

[PikeUK]

I was referring to the nsHelperAppDlg.js in
mozilla/toolkit/mozapps/downloads/content/ which is part of the cvs tree (it is
always restored by a checkout) and different to the nsHelperAppDlg.js.in in the
same folder.

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

-> 0.8

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Patch checked in. Thanks Pike!