228432 - Warning ``reference to undefined property selection.item[0]'' [xs] in file ``chrome://communicator/content/bookmarks/bookmarksTree.xml'', line 641, character 0.

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[timeless]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031208

Warning ``reference to undefined property selection.item[0]'' [xs] in file
``chrome://communicator/content/bookmarks/bookmarksTree.xml'', line 641,
character 0.
Stopped for error handler.
#0: function anonymous() in
<chrome://communicator/content/bookmarks/bookmarksTree.xml> line 641
639: var selection = this.mOuter.getTreeSelection();
640: this.mOuter._selection = selection;
641: this.mOuter._target = this.mOuter.getTreeTarget(selection.item[0],
selection.parent[0], BookmarksUtils.DROP_BEFORE);

Comment 1

[timeless]

Attachment: check selection length early (it's checked later)

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 137392 [details] [diff] [review]
check selection length early (it's checked later)

Could we store selection.length here if it's used later?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 137392 [details] [diff] [review]
check selection length early (it's checked later)

sr=bzbarsky either way.

Comment 4

[Andreas Kunz]

timeless: is there a reason why you have not checked this in?

Comment 5

[Alex Vincent [:WeirdAl]]

per bonsai, he did... 

Comment 6

[Andreas Kunz]

Heh... but only after my comment! :-)

Comment 7

[Andreas Kunz]

This probably caused bug 232827.

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #7)
> This probably caused bug 232827.

It did: reverting this patch "removes/hides" the new bug !
(for now, see there for more explanations)