228433 - Error ``node has no properties'' [xs] in file ``chrome://communicator/content/bookmarks/bookmarks.js'', line 1077, character 0.

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[timeless]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031208

Error ``node has no properties'' [xs] in file
``chrome://communicator/content/bookmarks/bookmarks.js'', line 1077, character 0.
Stopped for error handler.
#0: function anonymous(aInput=XPComponent:{7},
aArcURI=string:"http://home.netscape.com/NC-rdf#FolderGroup", aDS=void:void) in
<chrome://communicator/content/bookmarks/bookmarks.js> line 1077
1075: node = aDS .GetTarget(aInput, arc, true);
1076: try {
1077: return node.QueryInterface(kRDFRSCIID).Value;

Comment 1

[timeless]

Attachment: skip the try block for null node

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 137393 [details] [diff] [review]
skip the try block for null node

er, sure.  sr=bzbarsky

Comment 3

[[e-mail]]

Attachment: instanceof

This is an excellent example of the usefulness of instanceof.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 137654 [details] [diff] [review]
instanceof

sr=bzbarsky if you combine those if statements into a single if statement:

if (node instanceof foo || node instanceof bar)
  return node.Value;

Comment 5

[[e-mail]]

I also changed it to a ?: