228536 - Warning ``reference to undefined property this.onStandaloneImage'' [xs] in file ``chrome://communicator/content/nsContextMenu.js'', line 141, character 0.

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[timeless]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031208

Warning ``reference to undefined property this.onStandaloneImage'' [xs] in file
``chrome://communicator/content/nsContextMenu.js'', line 141, character 0.
Stopped for error handler.
#0: function anonymous() in <chrome://communicator/content/nsContextMenu.js>
line 141
139: // Set As Wallpaper depends on whether an image was clicked on, and only
works on Windows.
140: var isWin = navigator.appVersion.indexOf("Windows") != -1;
141: this.showItem( "context-setWallpaper", isWin && (this.onImage ||
this.onStandaloneImage));
142:
143: this.showItem( "context-sep-image", this.onImage || this.onStandaloneImage);

Comment 1

[timeless]

Attachment: add it to the constructor

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 137452 [details] [diff] [review]
add it to the constructor

sr=bzbarsky

Comment 3

[[e-mail]]

Attachment: Bail out earlier

Don't bother constructing the context menu if we're not going to show it.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 137668 [details] [diff] [review]
Bail out earlier

sr=bzbarsky; I'd say we want both of these patches...

Comment 5

[[e-mail]]

Fix checked in.