228550 - [import] Importing mail messages from Eudora stops after a little time, without any message, then crashes [@ ntdll.dll - nsEudoraCompose::ConvertSysToUnicode ]

Status: VERIFIED FIXED

(Thunderbird :: Migration, defect)

Description

[Antonio Angelo]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; it-IT; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Win98; it-IT; rv:1.4) Gecko/20030624

After having installed Thunderbird 0.4 (20031205), Italian localization, I run
successfully the Import utility for Address Book from Eudora (5.2.0.9 -
Sponsored Mode), while import of mail messages stops after a few minutes without
any warning. 
Available buttons in the window remains inhibited except for "Annulla" (Cancel).

Reproducible: Always

Steps to Reproduce:
1. Menu Strumenti > Importa... (Tools > Import)
2. Posta > Avanti (Mail > Next)
3. Select "Eudora", click Avanti (Next)

Actual Results:  
The procedure stops after a few minutes, without any warning. 
A new folder "Eudora Posta" (empty) appears under te tree "Local Folder"

Expected Results:  
I supposed to find the new folder "Eudora Posta" containing all messages
previously in Eudora.

Comment 1

[Ali Ebrahim]

I'm seeing this too on Thunderbird 0.7.1 on WinXP, importing mail from Eudora 6.1.2.

Talkback ID is TB221061Q.

Oddly enough, the crash is Thunderbird only. Mozilla 1.7 is able to import the
mail fine.

As comment 0 says, Thunderbird hangs. If you leave it for long enough (a few
hours), eventually it will crash. That's when I was able to send the talkback
report.

Comment 2

[Ali Ebrahim]

It appears that this crash may happen importing messages from Communicator 4.x
as well. I got a report on this on IRC.

Comment 3

[Quentin Vandermerwe]

I have the same problem with Mozilla 1.7 on Windows XP. Hangs for a long time
and then crashes.

Comment 4

[Adam Hauner]

Due to a recent Talkback database upgrade aren't older incidents available.
Could I ask you (Ali, Quentin, Antonio) again for TalkBack incident ID? I do
apologize for complication.

Comment 5

[Ali Ebrahim]

(In reply to comment #4)
> Due to a recent Talkback database upgrade aren't older incidents available.
> Could I ask you (Ali, Quentin, Antonio) again for TalkBack incident ID? I do
> apologize for complication.

Done. TB321661G.

This time I used the same steps to reproduce, but it crashed much faster. Yay!
If it's going to crash, it may as well do it quickly. :)

Comment 6

[Adam Hauner]

TB321661G:
ntdll.dll + 0x85c0 (0x77f585c0)
msvcrt.dll + 0x1ac14 (0x77c2ac14)
msvcrt.dll + 0x1ac2a (0x77c2ac2a)
nsEudoraCompose::ConvertSysToUnicode 
[e:/builds/tbird-0.7.2/WINNT_5.0_Clobber/mozilla/mailnews/import/eudora/src/nsEudoraCompose.cpp,
line 581]
nsEudoraCompose::GetHeaderValue 
[e:/builds/tbird-0.7.2/WINNT_5.0_Clobber/mozilla/mailnews/import/eudora/src/nsEudoraCompose.h,
line 134]
nsEudoraCompose::SendTheMessage 
[e:/builds/tbird-0.7.2/WINNT_5.0_Clobber/mozilla/mailnews/import/eudora/src/nsEudoraCompose.cpp,
line 601]
nsEudoraMailbox::ImportMailbox 
[e:/builds/tbird-0.7.2/WINNT_5.0_Clobber/mozilla/mailnews/import/eudora/src/nsEudoraMailbox.cpp,
line 287]
ImportEudoraMailImpl::ImportMailbox 
[e:/builds/tbird-0.7.2/WINNT_5.0_Clobber/mozilla/mailnews/import/eudora/src/nsEudoraImport.cpp,
line 530]
ImportMailThread 
[e:/builds/tbird-0.7.2/WINNT_5.0_Clobber/mozilla/mailnews/import/src/nsImportMail.cpp,
line 887]
_PR_NativeRunThread 
[e:/builds/tbird-0.7.2/WINNT_5.0_Clobber/mozilla/nsprpub/pr/src/threads/combined/pruthr.c,
line 455]
kernel32.dll + 0x1d33b (0x77e7d33b)

-> Migration

Comment 7

[trebor]

Similar crash on Eudora import on Mac OSX.  I have a full crash.log if it will help.  Seems to be in:

nsEudoraMailbox::FindStartLine(SimpleBufferTonyRCopiedOnce&) + 0x44

Comment 8

[trebor]

Added information:

It seems to have imported mailboxes more or less OK up until the point of the crash,

EXCEPT THAT:

0, 1 or more messages at the end of each mailbox seem to be missing (sometimes it gets it right, 
usually it misses 1 email, sometimes 2 or 3).

I have a nice test case, a mailbox with 4 emails in it, that TBird only imports 3 of.

Comment 9

[Scott MacGregor]

Attachment: possible patch for the crash

Adam I see you are running a debug build. Can you try this patch out to see if
it fixes the crash?

Comment 10

[Scott MacGregor]

I think I just checked in a fix for this into the the aviary branch for 0.8. Can
someone who sees this give tomorrow's nightly build (8/31) a spin?

Comment 11

[Asa Dotzler [:asa]]

Scott, we'll give this a good look first thing in the morning. 

Comment 12

[Scott MacGregor]

trebor, how is this looking in the 0.8 release? did the patch fix it?

Comment 13

[Scott MacGregor]

trebor, have you had a chance to see how this worked out in 0.8?

Comment 14

[Scott MacGregor]

I'm marking this fixed since this issue should have been branch only if the
patch really did fix it. 

Comment 15

[trix supremo]

verified importing from various mail apps: Eudora, Moz 1.7, etc... imports data
correctly on latest 20041124 builds