228762 - Dialog File Bookmark Keyword label has incorrect control attribute

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Met - Martin Hassman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ; rv:1.5) Gecko/20031007
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ; rv:1.5) Gecko/20031007

In the "File Bookmark" dialog (available as Bookmarks/File Bookmark...) you can
click on labels: Name, Location and the appropriate textbox is selected.

But this does not work for Keyword label, because the label has
control="shortcutURL" and the textbox has id="shortcutUrl"

Reproducible: Always

Steps to Reproduce:

Comment 1

[Met - Martin Hassman]

Attachment: Change keywords control attribute

one-line patch

Comment 2

[Jesiah S]

I see this on LInux 2003122707

Comment 3

[[e-mail]]

Comment on attachment 137569 [details] [diff] [review]
Change keywords control attribute

Actually we should be using for rather than control so that Alt+ shortcuts
work.

Also I'm not a superreviewer.

Comment 4

[[e-mail]]

Comment on attachment 137569 [details] [diff] [review]
Change keywords control attribute

I really should avoid trying to do reviews in my sleep.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 137569 [details] [diff] [review]
Change keywords control attribute

sr=bzbarsky, but in the future please do not ask me for sr on UI changes
anymore...

Comment 6

[Jan Varga [:janv]]

Comment on attachment 137569 [details] [diff] [review]
Change keywords control attribute

checked in

Comment 7

[Met - Martin Hassman]

->fixed

Comment 8

[Vaclav Dvorak]

*** Bug 226002 has been marked as a duplicate of this bug. ***

Comment 9

[Met - Martin Hassman]

-> verified