Closed Bug 228762 Opened 21 years ago Closed 20 years ago

Dialog File Bookmark Keyword label has incorrect control attribute

Categories

(SeaMonkey :: Bookmarks & History, defect)

Product:
SeaMonkey
Component:
Bookmarks & History
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(1 file)

Change keywords control attribute
694 bytes, patch
neil
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ; rv:1.5) Gecko/20031007
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ; rv:1.5) Gecko/20031007

In the "File Bookmark" dialog (available as Bookmarks/File Bookmark...) you can
click on labels: Name, Location and the appropriate textbox is selected.

But this does not work for Keyword label, because the label has
control="shortcutURL" and the textbox has id="shortcutUrl"

Reproducible: Always

Steps to Reproduce:
one-line patch
I see this on LInux 2003122707
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #137569 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #137569 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 137569 [details] [diff] [review]
Change keywords control attribute

Actually we should be using for rather than control so that Alt+ shortcuts
work.

Also I'm not a superreviewer.
Attachment #137569 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #137569 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #137569 - Flags: review-
Comment on attachment 137569 [details] [diff] [review]
Change keywords control attribute

I really should avoid trying to do reviews in my sleep.
Attachment #137569 - Flags: review- → review+
Attachment #137569 - Flags: superreview?(bzbarsky)
Comment on attachment 137569 [details] [diff] [review]
Change keywords control attribute

sr=bzbarsky, but in the future please do not ask me for sr on UI changes
anymore...
Attachment #137569 - Flags: superreview?(bzbarsky) → superreview+
Assignee: p_ch → met
Summary: Dialog File Bookmark Keword label has incorrect control attribute → Dialog File Bookmark Keyword label has incorrect control attribute
Comment on attachment 137569 [details] [diff] [review]
Change keywords control attribute

checked in
->fixed
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
*** Bug 226002 has been marked as a duplicate of this bug. ***
-> verified
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: