22879 - Download window should GetAttention when download is complete

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, enhancement, P3)

Description

[Matthew T (active 1999-2002)]

The dialog box which shows the progress of a download should have a checkbox in
it, below the progress indicator:

[ ] Alert me when this download is complete

If the checkbox is checked during the download, then when the download is
completed an alert box should be shown, telling the user that the download is
complete.

The checkbox should be off by default, so that (unlike with IE) repeated very
short downloads do not cause annoying and unnecessary `Download complete'
messages. Typically, a user would only check the checkbox if they were
downloading a file which was going to take several minutes, and wished to do
some other work in Mozilla while the download was taking place.

Comment 1

[don]

Good idea, actually ...

Comment 2

[Paul MacQuiddy]

spam: moving qa contact on some bugs from paulmac to [e-mail]

Comment 3

[don]

Move to "Future" milestone.

Comment 4

[Viswanath Ramachandran]

Since Don has left, Vishy is taking his bugs in bulk, pending reassignment.
thanks,
	Vishy

Comment 5

[Paul Chen]

nav triage team:

Don't think we'll get to this for beta1, marking nsbeta1-, reassigning to law

Comment 6

[sairuh (rarely reading bugmail)]

spam: over to File Handling.

Comment 7

[Jesse Ruderman]

Let's put some information in the taskbar icon conveying how far the download 
is (bug 36776), and then come back to see if this is necessary.

Comment 8

[Terrel Shumway]

A very simple change would provide much of the benefit with "no" added complexity:

When the download is complete, (i.e. in the same function that writes "download
completed" in the dialog) also change the dialog box caption from "saving file"
to "download completed".

Comment 9

[Terrel Shumway]

RE: comment #8

mozilla/embedding/components/ui/progressDlg/nsProgressDlg.js 

 61 // Indicate completion in status area.
 62 var msg = getString( "completeMsg" );
 63 msg = replaceInsert( msg, 1, formatSeconds( elapsed/1000 ) );
 64 dialog.status.setAttribute("value", msg);

dialog.title = msg
//or maybe
dialog.setTitle(msg)

 65 
 66 // Put progress meter at 100%.


I will do some more research to find out which is the correct syntax.
(And as soon as I can find this file in the install, I will even test it :-))

Comment 10

[Boris Zbarsky [:bzbarsky]]

The file's in chrome/toolkit.jar in the install
(content/global/progressDlg/nsProgressDlg.js inside the jar)

Comment 11

[Bill Law]

Please don't invest time working on that code.  It is being replaced; see
comments  in bug 27609 and the new code at
http://lxr.mozilla.org/seamonkey/source/embedding/components/ui/progressDlg/nsProgressDialog.js

That code does indicate completion in the title (i.e., "Saving foobar.zip (100%)").

Comment 12

[Blake Ross]

But the percentage should be first so it's visible in the taskbar.

Comment 13

[Bill Law]

OK, I'll buy that (subject to complaints from other kibitzers).  Can you make
that comment over in bug 27609 where the new progress dialog code is being reviewed?

Blake, you might want to have a look at the entire implementation of the dialog
so you can spot additional such stuff.

Comment 14

[Matthew T (active 1999-2002)]

Mister Law, sir! I would like to retract this bug. It's silly, and I'm 
embarrassed at having filed it. (In my defence, I was very young at the time.) 
GetAttention was made for this sort of thing.

Comment 15

[Bill Law]

Does that mean you want to modify it to say: "Download window should 'get
attention' when download completes"?

Comment 16

[Matthew T (active 1999-2002)]

Yep, that'd work. I'll add that when I next update the spec. Morphing summary.

Comment 17

[Mike Odom]

As far as I can tell, this already functions like this. Annoying too. I'll start
hundred meg downloads, go to play a game, and when the download is completed, I
get ripped out of whatever I'm doing to be told that the download is completed.
The work around for this is to check the 'close when completed' check box.

Comment 18

[Matthew T (active 1999-2002)]

No, that would be a separate bug. GetAttention does(/should) not focus windows.

Comment 19

[Christian :Biesinger (don't email me, ping me on IRC)]

taking bug

Comment 20

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 21

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 126779 [details] [diff] [review]
patch

r=bzbarsky

Comment 22

[jag (Peter Annema)]

Comment on attachment 126779 [details] [diff] [review]
patch

sr=jag

Comment 23

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in ui/progressDlg/nsProgressDialog.js;
/cvsroot/mozilla/embedding/components/ui/progressDlg/nsProgressDialog.js,v  <--
 nsProgressDialog.js
new revision: 1.29; previous revision: 1.28
done

Comment 24

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/b6248995a9e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/22879: Filter default engines when sending telemetry.