Closed
Bug 228794
Opened 21 years ago
Closed 21 years ago
biesi wants nsInterfaceHashtable::getWeak
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.7alpha
People
(Reporter: benjamin, Assigned: Biesinger)
References
Details
Attachments
(1 file)
|
2.70 KB,
patch
|
benjamin
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
biesi wants a way to get an interface pointer out of nsInterfaceHashtable
without the addref that Get() uses...
Interface* nsInterfaceHashtable::getWeak(KeyType aKey, PRBool* aFound = nsnull);
This shouldn't cost any codesize for people who aren't going to use it (and if
you use it exclusively it will cost less than Get).
|
Assignee | |
Comment 1•21 years ago
|
||
|
Reporter | |
Comment 2•21 years ago
|
||
Comment on attachment 138076 [details] [diff] [review]
patch
looks good to me. alecf needs to give approval
Attachment #138076 -
Flags: superreview?(alecf)
Attachment #138076 -
Flags: review+
|
|
Assignee | |
Updated•21 years ago
|
Assignee: bsmedberg → cbiesinger
Target Milestone: --- → mozilla1.7alpha
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 3•21 years ago
|
||
Comment on attachment 138076 [details] [diff] [review]
patch
can you make the header comments javadoc-style @param and @return?
|
|
Assignee | |
Comment 4•21 years ago
|
||
sure, will do that... tell me if you want a new patch for that
|
||
Comment 5•21 years ago
|
||
Comment on attachment 138076 [details] [diff] [review]
patch
awesome!
sr=alecf
Attachment #138076 -
Flags: superreview?(alecf) → superreview+
|
|
Assignee | |
Comment 6•21 years ago
|
||
checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•