228799 - Opening Chatzilla gives "Invalid IRC URL ``%S"

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Frank Wein [:mcsmurf]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031127
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031217

see steps to reproduce

Reproducible: Always

Steps to Reproduce:
1. Click on Window-IRC Chat
Actual Results:  
The error message "Invalid IRC URL ``%S" pops up; Chatzilla opens anyway

Expected Results:  
not popup the error message (and open Chatzilla :)

Comment 1

[Frank Wein [:mcsmurf]]

I think this regressed between 2003-10-15 and today, so should be easy to 
figure out

Comment 2

[Samuel Sieb]

What version of chatzilla are you using? (/about)

Comment 3

[James Ross]

Yesterday a fix was put in to make irc:/// (now an invalid URL) throw up this
message, where as before you'd get a silent JS exception. At the same time, the
pref pages were fixed to not default to irc:/// - which is the most likely
reason to have irc:/// in the intialURLs pref. The message is by design, though
it's clear it's not putting the URL in where it should.

Comment 4

[James Ross]

Attachment: cvs diff to deal with irc:/// in initialURLs

This change makes Chatzilla automatically replace (and save the result) irc:///
items in initialURLs with irc://. It also fixes the "Invalid IRC URL" message,
so it shows the URL passed.

Comment 5

[Robert Ginda]

Comment on attachment 137620 [details] [diff] [review]
cvs diff to deal with irc:/// in initialURLs

please add a comment in there that explains how irc:/// might have gotten in to
the pref to begin with, other than that it looks great.  r=rginda.

Comment 6

[James Ross]

Comment on attachment 137620 [details] [diff] [review]
cvs diff to deal with irc:/// in initialURLs

Removes now-unsuported URL entires (no effect on localisation).

Comment 7

[chris hofmann]

Comment on attachment 137620 [details] [diff] [review]
cvs diff to deal with irc:/// in initialURLs

a=chofmann for 1.6.  this needs to go on the branch at this point to get into
1.6.

Comment 8

[James Ross]

Checked into HEAD and MOZILLA_1_6_BRANCH.