Closed Bug 228882 Opened 21 years ago Closed 21 years ago

The fix for the bad code checked in for bug 132517 is missing from the 0.8 branch

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firebird0.8

People

(Reporter: wgianopoulos, Assigned: p_ch)

References

Details

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031214 Firebird/0.7+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031214 Firebird/0.7+ There were 2 checkins on December 16th for bug 132517. The first checkin broke things so that the prefs.js file was never saved if there was no prefs.js file to start with (like when you have a new profile). This was corrected by a subsequent check-in later in the day. However it appears that the 0.8 branch was cut between the 2 checkins so the 0.8 branch has the broken code. This code: http://bugzilla.mozilla.org/attachment.cgi?id=137552&action=view needs to be applied. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Flags: blocking0.8?
Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031217 Firebird/0.7+
An alternative solution would be to back-out the earlier check-in for bug 132517 from the branch. The way it is now is seriously broken.
-> Ben, for what it's worth
Assignee: blake → bugs
Flags: blocking0.8? → blocking0.8+
*** Bug 228806 has been marked as a duplicate of this bug. ***
*** Bug 229008 has been marked as a duplicate of this bug. ***
Pierre, can you land the patch at http://bugzilla.mozilla.org/attachment.cgi?id=137552&action=view on the branch please?
pierre, see previous comment, this should get on the branch ASAP please
*** Bug 229012 has been marked as a duplicate of this bug. ***
Target Milestone: --- → Firebird0.8
I backed out the patch in bug 132517. The same has already been done in the trunk and will be done shortly on thz 1.6 branch.
Assignee: bugs → p_ch
bug report is fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → preferences
You need to log in before you can comment on or make changes to this bug.