228888 - Pref to limit the number of pref file backups is ignored

Status: VERIFIED FIXED

(Core :: Preferences: Backend, defect)

Description

[Stephen Walker]

user_pref("backups.number_of_prefs_copies", 0); is ignored in today's build; a
new prefs.bak is created on every shutdown.

Comment 1

[Sven Grull]

I had this morning more than 20 pref backup files in my profile named
prefs-?.bak and prefs-?-?.bak

Comment 2

[bomfog]

WFM: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031216

Build ID: 2003121608

BROKEN: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031217

Build ID: 2003121709

Both builds unzipped to the desktop and run from there with a fresh profile.

P3 500 MHz, 256 MB RAM, XP pro

Reproduce by:

1. Open rock-stock moz from the zip dist., with a fresh profile.
2. Close immediately, profile directory looks normal
3. Repeat 1 and 2.

Expected: profile directory continues to look normal.

Actual: prefs-2.bak appears at second closing, continued repetitions add
prefs-3.bak and etc.

Also: Saw more elaborate backup numbering schemes as reported in Comment #1, but
that was with a well-used profile, installed extensions, etc.  Didn't happen
with above procedure.

More Also: Had problems with prefs not persisting between sessions, but again
with dirty profile, etc.  Seemed to be of somewhat variable occurance.  Will
fumble around attempting to investigate further. Degree of relevance deponent
knoweth not.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

should work again in curretn builds, per bug 132517 comment 64.

Comment 4

[Stephen Walker]

verified.

Comment 5

[Michael Lefevre]

Just for the record, this bug is still present in the 1.6 branch - the backout
hasn't happened there yet.

Comment 6

[Michael Lefevre]

it's been backed out now...