228988 - XPInstall - "Installation complete / restart" message always shown

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect, P2)

Description

[Michael O.]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) Gecko/20031218 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) Gecko/20031218 Firebird/0.7+

When installing an extension, the "Installation complete / restart" message is
always displayed afterward, even if the installation was aborted due to error or
cancelInstall() callback.

I have a small XPInstall package at http://cosmicat.com/x/build_id.xpi which can
be used for testing this behavior, as it does not install any components and
calls cancelInstall() to abort the procedure.

Reproducible: Always

Steps to Reproduce:
1. Install an extension that is known to abort installation.

Actual Results:  
"Installation complete / restart" message is displayed.

Expected Results:  
Error message should be displayed. The previous XPInstall UI displayed error
codes and short descriptions for errors and cancelInstall().

Comment 1

[Jimmy McCrory]

Confirmed
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031218
Firebird/0.7+

Comment 2

[alanjstr]

Was I supposed to click OK or Cancel?  Clicking Cancel seems to exit.  I clicked
OK and I got an alert and then a status of Cancelled.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031216
Firebird/0.7+

Comment 3

[Jesse Ruderman]

Is this bug a regression?  Is it branch-only?

Comment 4

[Michael O.]

Attachment: Win98 behavior illustrated

Just to make things clear -- this attachment illustrates the behavior observed
on Windows 98, now using a 20031226 branch build. XPInstall error messages are
never displayed.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

-> 0.9

Comment 6

[Ali Ebrahim]

taking qa

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Will be fixed by new EM. 

Comment 8

[Jimmy McCrory]

Now that the EM is in, can this be marked fixed?
I just tried the test package and an alert is now displayed.