229036 - start menu links to 'readme' and 'license' don't work

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Rob Hudson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031218 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031218 Firebird/0.7+

When using the latest official installer the 'readme' and 'license' links in the
start menu don't work.

Reproducible: Always

Steps to Reproduce:
1. Go to the start menu
2. Go to the Mozilla Firebird Folder
3. Click on either 'Readme' or 'License'

Actual Results:  
Windows fails to find either file.

Expected Results:  
Open up 'readme.txt' or 'license.txt'

Comment 1

[Frederic Bezies]

Confirming with both official installer and my homemamde builds.

So this under WinXP-Sp1.

Could be considered as a 0.8 blocker, so setting ? at blocking0.8 flag.

Comment 2

[Frederic Bezies]

Here is the listing I get (under a Win98se) for c:\program files\mozillafirebird\

              <REP>        20/12/03  17:01 .
..             <REP>        20/12/03  17:01 ..
INSTAL~1 LOG           558  20/12/03  17:02 install_wizard.log
INSTAL~2 LOG         2 312  20/12/03  17:02 install_status.log
PLUGINS        <REP>        20/12/03  17:01 plugins
XPCOM    DLL       438 272  19/12/03   0:40 xpcom.dll
COMPON~1       <REP>        20/12/03  17:01 components
XPCOM_~1 DLL       126 976  18/12/03  18:16 xpcom_compat.dll
JS3250   DLL       339 968  18/12/03  18:10 js3250.dll
PLC4     DLL        28 672  18/12/03  18:05 plc4.dll
PLDS4    DLL        24 576  18/12/03  18:05 plds4.dll
XPISTUB  DLL        24 576  18/12/03  20:11 xpistub.dll
NSPR4    DLL       155 648  18/12/03  18:05 nspr4.dll
AUTORE~1                 0  20/12/03  17:01 .autoreg
SOFTOKN3 CHK           476  18/12/03  19:59 softokn3.chk
CHROME         <REP>        20/12/03  17:01 chrome
RES            <REP>        20/12/03  17:01 res
DEFAULTS       <REP>        20/12/03  17:01 defaults
NSS3     DLL       344 064  18/12/03  19:58 nss3.dll
XPICLE~1 EXE        77 824  18/12/03  20:11 xpicleanup.exe
NSSCKBI  DLL       176 128  18/12/03  19:59 nssckbi.dll
SSL3     DLL       110 592  18/12/03  19:58 ssl3.dll
SMIME3   DLL       106 496  18/12/03  19:58 smime3.dll
MOZILL~1 EXE     6 742 016  19/12/03   1:13 MozillaFirebird.exe
SOFTOKN3 DLL       364 544  18/12/03  19:57 softokn3.dll
UNINST~1       <REP>        20/12/03  17:02 uninstall
SEARCH~1       <REP>        20/12/03  17:02 searchplugins

No license, nor readme.txt

Maybe tweaking package-config in /mozilla/browser/installer/windows could help ?

Comment 3

[Frederic Bezies]

Here is a workaround to get all icons of start menu working - I hope coders
could make it more clean :

1) Copy from root directory both LICENSE and README.txt

2) rename LICENSE to license.txt

3) Modify package-config file, adding those 2 lines in [browser section]
bin\license.txt
bin\README.txt

4) Make installer, launch it and see.

I used this trick with my 20th december installer 0.8 build, downloadable here :

http://pryan.org/firebird/mozjf/

(6.14 Mb) 

Comment 4

[alanjstr]

They're not in the zip file, either.  

Comment 5

[Simon Paquet [:sipaq]]

Attachment: Adding LICENSE and README.txt to the distribution

This adds the LICENSE and README.txt file to the Mozilla Firebird distribution
and the installer. 

We should be aware of the fact, that the README.txt file is very much targeted
at Seamonkey. A Rewrite may be necessary, but that should be covered in another
bug.

Comment 6

[Simon Paquet [:sipaq]]

Taking.

Comment 7

[Simon Paquet [:sipaq]]

Accepting

Comment 8

[Frederic Bezies]

Wow :)

Superb :)

I am only waiting to get this checked in before releasing a new 0.8 build :)

Thanks :)

Comment 9

[Simon Paquet [:sipaq]]

Attachment: Make the license start menu entry work

At the moment the installer creates start menu entries for license.txt
But our license file is named LICENSE without the .txt file extension.

Comment 10

[Robert Parenton]

Simon,

Although it doesn't matter on Windows, we should probably use the correct case
of the filename in the shortcut.  As in LICENSE instead of license.

Comment 11

[alanjstr]

per ben on IRC

Comment 12

[alanjstr]

Looks like LICENSE and README.html went onto the 0.8 branch.

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 138699 [details] [diff] [review]
Adding LICENSE and README.txt to the distribution

r=[e-mail]

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 138718 [details] [diff] [review]
Make the license start menu entry work

r=[e-mail]

Comment 15

[Simon Paquet [:sipaq]]

Ben checked this in. Marking FIXED.

Comment 16

[Carl Schrader]

FWIW, this checkin messed up splash.rc. Firefox Debug is back in both cases..

Comment 17

[David Hallowell]

This patch has a problem, as licence doesn't have an extension clicking the
licence link will have Windows asking you what application to use to open the
file. In bug 232477 comment 4 I give my reasons why I think the license and
readme links should be removed and the link to the executable moved to directly
under the Programs part of the start menu like IE is

Comment 18

[alanjstr]

(In reply to comment #16)
> FWIW, this checkin messed up splash.rc. Firefox Debug is back in both cases..

Ben also checked in some splash.rc stuff to fix that already. 

Comment 19

[Simon Paquet [:sipaq]]

*** Bug 241283 has been marked as a duplicate of this bug. ***

Comment 20

[Bill Mason]

*** Bug 242092 has been marked as a duplicate of this bug. ***