Closed Bug 229062 Opened 21 years ago Closed 20 years ago

Clicking Download Notification/link does not show Download Manager

Categories

(Toolkit :: Downloads API, defect, P2)

Product:
Toolkit
Component:
Downloads API
Platform:
x86
Windows XP
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.7.4

People

(Reporter: bugzilla, Assigned: bugs)

References

Details

(Keywords: fixed-aviary1.0, regression)

Attachments

(1 file)

patch
2.01 KB, patch
Details | Diff | Splinter Review 
The Download Notification alert is a bit confusing, when I see that its
underlinded I expect it to do something when I click on it. Nothing happends though.

For example, I am downloading several files, to different locations. When a
download is done, I get this notification and clicking on it should take me to
the files location. But now nothing happends.

Using 20031218 0.8 branch build.
As per the comment at 
http://lxr.mozilla.org/mozilla/source/toolkit/components/downloads/src/nsDownloadManager.cpp#2042

the alert is clickable only when the DM is not automatically cleared.  The
underline appears, but clicking it does nothing.

Confirming Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b)
Gecko/20031216 Firebird/0.7+
Summary: Download Notification not clickable → Clicking Download Notification does not show Download Manager
Summary: Clicking Download Notification does not show Download Manager → Clicking Download Notification/link does not show Download Manager
*** Bug 230509 has been marked as a duplicate of this bug. ***
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Firebird0.9
*** Bug 231209 has been marked as a duplicate of this bug. ***
*** Bug 231323 has been marked as a duplicate of this bug. ***
*** Bug 234287 has been marked as a duplicate of this bug. ***
*** Bug 236453 has been marked as a duplicate of this bug. ***
*** Bug 234211 has been marked as a duplicate of this bug. ***
QA Contact: aebrahim
*** Bug 236818 has been marked as a duplicate of this bug. ***
Target Milestone: Firefox0.9 → Firefox1.0beta
A problem is that downloading sometimes reports a successful complete even if 
only a portion was downloaded. When i donwload a 3000 k file and its only  789k 
it is not complete. Firefox shall get that is was an unsuccessful download.
Flags: blocking0.9?
The target is Firefox1.0beta, so this doesn't block Firefox 0.9.
Flags: blocking0.9? → blocking0.9-
*** Bug 241771 has been marked as a duplicate of this bug. ***
Flags: blocking1.0?
Flags: blocking1.0? → blocking1.0+
*** Bug 244287 has been marked as a duplicate of this bug. ***
Ben, what's the expected behavior here?  I assume it's to open the Downloads
window.  Once you clarify that, I'll try and fix this.
(In reply to comment #13)
> Ben, what's the expected behavior here?  I assume it's to open the Downloads
> window.  Once you clarify that, I'll try and fix this.

That's correct. The download manager is supposed to display when you click the
link. I can't think of any other behaviour that makes sense.
*** Bug 245838 has been marked as a duplicate of this bug. ***
> > Ben, what's the expected behavior here?  I assume it's to open the Downloads
> > window.  Once you clarify that, I'll try and fix this.

> That's correct. The download manager is supposed to display when you click the
> link. I can't think of any other behaviour that makes sense.

3 of the duplicate bugs ( that's all I've checked) have assumed it would go to
the downloaded file in windows explorer/file manager, not the download manager.
Perhaps an option to say - go to download manager, or go to last downloaded file
location? 

Two clicks in both cases: 
- one to downlaod manager, then another to open the download. 
versus 
- one click to go to the enclosing directory. Another to open the download.

I don't always want to open straight away. I want to go to the enclosing folder
to scan it, or see other things I've downloaded in there at the same time.

My 2c worth.


*** Bug 246125 has been marked as a duplicate of this bug. ***
Mark, I believe it would make better sense to make the link open the Download
Manager, simply because of the fact that if one downloads several files
concurrently, it would be better to handpick which file is to be opened, which
is done easily through the manager. Of course, I'm only talking about Firefox's
default behaviour.

Besides, I think (not sure on this) the alert only pops up when all the current
files have been downloaded, and making Firefox launch all the "recent" downloads
at once just doesn't sound very usable (just imagining several separate sessions
of a huge program such as Photoshop is scary for the average PC, or worse, a
program which doesn't allow multiple instances could go haywire and crash).

Your suggestion on selecting the default behaviour for the link should probably
become an extension, to allow Power Users to tweak such a thing.
(In reply to comment #18)
> Your suggestion on selecting the default behaviour for the link should probably
> become an extension, to allow Power Users to tweak such a thing.

Cool - so default is download manager, and then if you get time to do it, you
can do the customisation option - fine with that! 


*** Bug 247152 has been marked as a duplicate of this bug. ***
Ah, sorry, I created that last duplicate... Anyways, what I have said there and
haven't seen mentioned here:

When it opens/focuses the download manager, it should select the finished
download the popup was about...

p.s. opening the download location is weird, if you ask me :). I hope you won't
implement that behaviour. From within the download manager, it is a single click
on 'show' to open the file location, easy enough, and it offers other handy
functionality (such as open/run) as well. It will also make the download
manager easier to find for people not accustomed to it (such as 'dummy' users
moving from IE). About adding an option for different behaviour, I don't know if
that is desireable, it sounds an awful lot like the Mozilla-the-Suite 'add every
possible option' policy...

p.s.2. I'm glad to see this is a blocking1.0 :).


~Grauw
*** Bug 247248 has been marked as a duplicate of this bug. ***
Attached patch patch — — Splinter Review 
- make sure nsDownloadManager implements QI magic for nsIAlertListener so that
the QI in the alert prompt dialog will actually succeed!
fixed br & trunk. 
fixed br & trunk.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Oh sure, steal my thunder.
Works fine! -> v.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040701
Firefox/0.9.0+ (Steffen)
Status: RESOLVED → VERIFIED
*** Bug 249534 has been marked as a duplicate of this bug. ***
*** Bug 246325 has been marked as a duplicate of this bug. ***
*** Bug 249846 has been marked as a duplicate of this bug. ***
*** Bug 250204 has been marked as a duplicate of this bug. ***
*** Bug 251255 has been marked as a duplicate of this bug. ***
*** Bug 252238 has been marked as a duplicate of this bug. ***
*** Bug 252539 has been marked as a duplicate of this bug. ***
*** Bug 252636 has been marked as a duplicate of this bug. ***
*** Bug 254950 has been marked as a duplicate of this bug. ***
*** Bug 254969 has been marked as a duplicate of this bug. ***
*** Bug 255871 has been marked as a duplicate of this bug. ***
Keywords: fixed-aviary1.0
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20041213
Firefox/1.0+

This regressed on TRUNK between the 20041212-08 and 20041213-08 (PST) builds (Win)
Status: VERIFIED → REOPENED
Keywords: regression
Resolution: FIXED → ---
Checkins 20041212-08 PST to 20041213-08 PST:

bug 36322 [Core]-Japanese text justification [All]
bug 267089 [Firefox]-Remove nsIAlertListener from toolkit [All]
bug 268119 [Core]-Freeze/crash with [@ 0x0000189c nsBlockFrame::AddFrames]
:first-letter inside absolute positioned div [@
nsCSSFrameConstructor::WrapFramesInFirstLetterFrame] [All]
bug 272079 [Core]-decomtaminate nsIContent::GetNameSpaceID() [All]

Wild guess, bug 267089 ?
I checked in a typo fix for bug 267089. Please mark this bug fixed if that fixed it.
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20041221
Firefox/1.0+

Just checked the latest build, it's working again.
Thanks Steffen

->RESOLVED/FIXED
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
Something similar is happening to me in Linux (Linux Mint 16 Mate). When i click on the "Download" icon to see the donload progress, nothing is shown. I see a flash of a window for a milisecond, as if the download manager tries to open, but it doesn't work.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: