229072 - When editting startup "Also connect to the..." box contents are greyed out

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Ian Neal]

Steps to reproduce
1. Enter #mozillazine and right click on channel and select "Open This Channel
at Startup"
2. Select Edit, Preferences, Chatzilla, Startup
3. Select mozillazine on moznet in "Autoconnect servers" window and then Edit
4. Chatzilla Autoconnect Item window pops up

Expected result
1. Contents of "Also connect to the..." box are editable

Actual result
1. Contents of "Also connect to the..." box are disabled

Workaround
1. Uncheck and recheck the "Also connect to the..." checkbox

Other info
JS console gives the following error message:
Error: params[3] has no properties
Source File: chrome://chatzilla/content/prefpanel/startup-newURL.js
Line: 84

Comment 1

[Ian Neal]

Attachment: Patch v0.1 checks to see if params[3] exists

This hacks round the problem, not sure why params.length = 4 if params[3] is
void

Comment 2

[Ian Neal]

Comment on attachment 137771 [details] [diff] [review]
Patch v0.1 checks to see if params[3] exists

Requesting r=

Comment 3

[Robert Ginda]

Comment on attachment 137771 [details] [diff] [review]
Patch v0.1 checks to see if params[3] exists

params[3] will be null in recent builds if the final group doesn't match
anything.

The length check should be changed to a call to arrayHasElement, as in bug
223247.

However, Silver is working on code that will replace everything in prefpanel/. 
This code won't be around much longer.

Comment 4

[Ian Neal]

Attachment: Patch v0.2 checks using arrayHasElementAt

Just in case we want a temporary fix for 1.6 final

Comment 5

[Ian Neal]

The checkin for bug 85721 caused this problem then -> regression but minor as
there is a workaround. What is the bug number that Silver is working on?

Comment 6

[Robert Ginda]

Comment on attachment 137787 [details] [diff] [review]
Patch v0.2 checks using arrayHasElementAt

r=rginda

Comment 7

[James Ross]

Comment on attachment 137787 [details] [diff] [review]
Patch v0.2 checks using arrayHasElementAt

Checked in.