229083 - keyword.enabled preference is required.

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Doug Turner (:dougt)]

There is no clear reason why this pref shouldn't be optional defaulting to some
value (probably false)

Comment 1

[Patrick McCormick]

Attachment: patch that makes the presence of "keyword.enabled" optional, defaults to false

I agree, that's kind of harsh.	Attached is a patch that makes the presence of
the pref optional.  If it is not there, we assume false.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I don't believe the prefs api guarantees not touching the out param on failure
(XPCOM apis generally do not).  So you need to set the our param to your default
value if the call fails.  Other than that, looks reasonable.

Comment 3

[Patrick McCormick]

Attachment: revised to handle failure case

revision as per bz's comment.

note that nsDocShell::Create calls mPrefs multiple times without checking the
retval, so we might want to clean that up in the future.

Comment 4

[Patrick McCormick]

Comment on attachment 139965 [details] [diff] [review]
revised to handle failure case

oops, I got that all backwards.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 139817 [details] [diff] [review]
patch that makes the presence of "keyword.enabled" optional, defaults to false

Please remove obsolete review requests...

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 139965 [details] [diff] [review]
revised to handle failure case

r+sr=bzbarsky.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Checked in.