229096 - Blank toolbar after 19-Dec builds. No Icons at all.

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mickey Stein]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20031220 Firebird/0.7+ (Optimized for Athlon XP SSE by Yek)
Build Identifier: Mozilla Thunderbird 0.5a (20031220) (or 21-Dec as well)

My build (on FC1) using gcc 3.3.2-2 and glic-2.3.2* worked fairly well on
19-Dec, but somewhere's among the checkin's of late on the 19th and early on the
20th, this problem came into being. 

No icons are visible on builds after the 20th. This doesn't occur on mozilla
builds post-19th. The toolbar(s) are completely blank regardless of theme
including MozillaFirebird default. No profile was used, and an old profile was
tried, but no difference. 



Check this thread for other's with this problem on their builds:
http://forums.mozillazine.org/viewtopic.php?p=305942#305942



Reproducible: Always

Steps to Reproduce:
1. checkout CVS as of ~600 PST 20-Dec
2. build
3. run tbird, look at empty toolbar.

Actual Results:  
Saw completely empty toolbar.

Expected Results:  
Shown normal toolbar. I'll supply some images if I can to illustate. 

Linux, Fedora core 1, athlonxp , nforce2 mobo,

source from cvs co of 20-Dec ~600 PST.

Comment 1

[Mickey Stein]

Attachment: Image of proble. Toolbar sans icons.

This is how the toolbar appears (blank) on builds form cvs 20-dec and 21-dec.
(or until it's fixed :))

Comment 2

[Mickey Stein]

And finally, (I always forget), my .mozconfig for these builds.

export MOZ_THUNDERBIRD=1
mk_add_options MOZ_THUNDERBIRD=1
ac_add_options --enable-crypto
ac_add_options --disable-mathml
ac_add_options --disable-installer
ac_add_options --disable-activex
ac_add_options --disable-activex-scripting
ac_add_options --disable-tests
ac_add_options --disable-oji
ac_add_options --disable-necko-disk-cache
ac_add_options --disable-debug
#ac_add_options --enable-debug
ac_add_options --disable-profilesharing
ac_add_options --enable-image-decoders=png,gif,jpeg,bmp
ac_add_options --enable-extensions=wallet,spellcheck,xmlextras
ac_add_options --enable-necko-protocols=http,file,jar,viewsource,res,data
ac_add_options "--enable-optimize=-O3 -march=athlon-xp -msse "
ac_add_options --enable-xft
ac_add_options --disable-freetype2
ac_add_options --enable-default-toolkit=gtk2

Comment 3

[Mickey Stein]

Some debug output around a point that I can see is related. Clicking on
view/toolbars/customize will show a blank frame without widgets and this is the
debug from that area:

hrome/messenger.jar!/content/messenger-smime/
*** Chrome Registration of locale : Checking for contents.rdf at
jar:resource:/chrome/en-US.jar!/locale/en-US/messenger-smime/
*** Chrome Registration of package: Checking for contents.rdf at
jar:resource:/chrome/messenger.jar!/content/messenger/
*** Chrome Registration of package: Checking for contents.rdf at
jar:resource:/chrome/messenger.jar!/content/messenger-region/
*** Chrome Registration of locale : Checking for contents.rdf at
jar:resource:/chrome/en-US.jar!/locale/en-US/messenger/
*** Chrome Registration of locale : Checking for contents.rdf at
jar:resource:/chrome/US.jar!/locale/US/messenger-region/
*** Chrome Registration of package: Checking for contents.rdf at
jar:resource:/chrome/comm.jar!/content/help/
GFX: dpi=96 t2p=0.0666667 p2t=15 depth=24
WEBSHELL+ = 1
[New Thread 1144708016 (LWP 23994)]
[New Thread 1153100720 (LWP 23995)]
WEBSHELL+ = 2
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsChromeRegistry.cpp,
line 3185
WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file nsChromeRegistry.cpp,
line 3185
Note: verifyreflow is disabled
Note: styleverifytree is disabled
Note: frameverifytree is disabled
[New Thread 1161608112 (LWP 23998)]
[New Thread 1170000816 (LWP 23999)]
[New Thread 1178393520 (LWP 24000)]
WEBSHELL+ = 3
WEBSHELL+ = 4


************* I think this is the source of the troubles,
************* this next sections is after click on view/toolbars/customize
************* which brings up a blank customize screen, (no widgets).

WEBSHELL+ = 3
WEBSHELL+ = 4
[New Thread 1180666800 (LWP 24639)]
WEBSHELL+ = 5
JavaScript error:
chrome://global/content/customizeToolbar.js line 374: gToolbox.palette has no
properties

Comment 4

[Scott MacGregor]

*** Bug 229097 has been marked as a duplicate of this bug. ***

Comment 5

[Andrew Benton]

I'd vote for this to be fixed, but I can't see where to, so I'll just say "me
to". This is affecting my builds.

Comment 6

[Scott MacGregor]

fixed the regression. 

mozilla/toolkit/content/jar.mn

Comment 7

[Andrew Benton]

Thankyou

Comment 8

[Mickey Stein]

Thanks Scott:

Question about the form of the jar.mn files:

Does "content/global/bindings/general.xml  (widgets/general.xml)"
imply that general.xml does *not* become part of the toolkit.jar?

	
and conversely:
"*+ content/global/bindings/general.xml         (widgets/general.xml)"
implies that it does? 

Thanks. 

*

Comment 9

[Scott MacGregor]

+ means overwrite the existing file in the jar with the same name. Without the
plus, it only gets added if the file date is newer than the one already in the jar.

Since xpfe gets built first, the old xpfe version of toolbar.xml is already in
there. This ensures that we always replace the xpfe version with toolkit's.

Comment 10

[Mickey Stein]

I see. Thanks for the explanation. Yet another thing I didn't know (what a
surprise:))