229100 - shift-tab is broken inside search-bar

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[Kevin Brosnan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031216 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031216 Firebird/0.7+

If focus is in the quick search box, shift tab does nothing.

Reproducible: Always

Steps to Reproduce:
1. click in the quick search box
2. press shift tab


Actual Results:  
nothing happens focus remanins in search box

Expected Results:  
Focus should have switched to the address bar.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Confirming with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a)
Gecko/20040110 Firebird/0.8.0+ (mozJF)

Comment 2

[Ruffilli Simone]

Confirmed on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a)
Gecko/20040106 Firebird/0.7+

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7a)
Gecko/20040127 Firebird/0.8.0+ (scragz).

-> Changed summary to better fit the problem.

Comment 4

[Mike Connor [:mconnor]]

*** Bug 234766 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Connor [:mconnor]]

From Jesse Ruderman in the dupe:

"This worked in Dec 2 builds and stopped working in Dec 3 builds.  It might have
been caused by Ben's fix for bug 171606."

Comment 6

[Jon Wichman]

Cannot shift-tab backwards completely through window.

This makes movement from first link to last link which,
should only take three shift-tabs impossible to do.

It makes navigation without a mouse more difficult as
you can only move in one direction and, if you miss it,
you have to tab all of the way forward again.

I think that this should be an accessibility issue also -
if that category were available for Firefox.

Comment 7

[Scott Gifford]

This is also annoying because you can TAB from the URL bar to the search bar, so
if you fat-finger the tab key while typing in a URL, you can't undo the damage
without the mouse.

Comment 8

[Jesse Ruderman]

*** Bug 238179 has been marked as a duplicate of this bug. ***

Comment 9

[José Jeria]

*** Bug 239145 has been marked as a duplicate of this bug. ***

Comment 10

[José Jeria]

*** Bug 240200 has been marked as a duplicate of this bug. ***

Comment 11

[Dan Rawson]

Confirmed on Solaris
Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.6) Gecko/20040403 Firefox/0.8

Comment 12

[Kevin Brosnan]

This breaks keyboard navigation in the browser, so I am nominating for blocking 1.0.

Comment 13

[Yan Morin]

You can come back with the keyboard, but the user don't always know every
shortcuts like CTRL-L

Comment 14

[alanjstr]

Only peers should be setting these to +

Comment 15

[Mike Connor [:mconnor]]

yeah, this is annoying, time to get some traction on it, but its not critical
for 0.9

Comment 16

[José Jeria]

*** Bug 242853 has been marked as a duplicate of this bug. ***

Comment 17

[Eamon McDermott]

Broken UI components that should take a few minutes to fix aren't critical?

Comment 18

[Paul Sladen]

I switched from Firebird $something_reliable to 0.9 and this annoyed me SO MUCH
I felt compelled to deal with it after about 3hours! :-)

The problem is that `search-proxy-button' (the Google/OtherSearchEngine dropdown
selector) is getting the focus and then immediately giving it to its parent
('seach-container/search-bar').  In the process of figuring out XUL, I tried
various fixes including the settting the tabindex="2" and having a
onfocus/onblur handler deal with it but these all introduced small side-effects.

The best fix seems quite simply to add:

  #search-proxy-button {
    -moz-user-focus: none;
  }

somewhere appropriate (eg. `browser.css').

  -Paul Sladen

Comment 19

[Mike Connor [:mconnor]]

any particular reason you reassigned this?

-> taking back.

Comment 20

[Mike Connor [:mconnor]]

Attachment: the fix, based on Paul's comment

Comment 21

[Mike Connor [:mconnor]]

fixed, branch and trunk

thanks for tracking this down Paul!

Comment 22

[Jesse Ruderman]

*** Bug 249983 has been marked as a duplicate of this bug. ***

Comment 23

[Justin Kerk]

*** Bug 250919 has been marked as a duplicate of this bug. ***

Comment 24

[José Jeria]

*** Bug 252310 has been marked as a duplicate of this bug. ***

Comment 25

[Ryan Polk (Quark)]

*** Bug 252557 has been marked as a duplicate of this bug. ***

Comment 26

[Jesse Ruderman]

*** Bug 253799 has been marked as a duplicate of this bug. ***

Comment 27

[Aaron Leventhal]

*** Bug 257418 has been marked as a duplicate of this bug. ***

Comment 28

[Gérard Talbot]

*** Bug 257712 has been marked as a duplicate of this bug. ***

Comment 29

[Aaron Leventhal]

*** Bug 257842 has been marked as a duplicate of this bug. ***