229172 - class attribute case insensitive when used with [class=""] (also archive, cite, datetime, href, and name attributes)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Hixie (not reading bugmail)]

[class=foo] shouldn't match <p class="FOO"> and yet it does.

Test: http://www.hixie.ch/tests/adhoc/html/case-sensitivity/002.html

Comment 1

[Gilles Durys]

This is similar to bug 12386.

Comment 2

[Gilles Durys]

Attachment: Adapted patch from bug 12386

Comment 3

[Hixie (not reading bugmail)]

While you're at it, I noticed we should also add the following attributes to the
case sensitive list: archive, cite, datetime, href, name

Testcase: http://www.hixie.ch/tests/adhoc/html/case-sensitivity/003.html

Comment 4

[Gilles Durys]

Attachment: Updated patch

This updated patch contains all new attributes.

All tests with the substring selector and capital value (some_attr*="TEST")
still fail.
Somebody who knows more about the CSS parser might want to take a look.

Comment 5

[Gilles Durys]

http://lxr.mozilla.org/mozilla/source/content/html/style/src/nsCSSStyleSheet.cpp#3425
For |NS_ATTR_FUNC_CONTAINSMATCH|, a case-insensitive comparator is always used.

Comment 6

[Gilles Durys]

Attachment: Also fixes case-sensitivity for substring selector

Comment 7

[Hixie (not reading bugmail)]

For historical reference, this was broken by alecf back in May 2002 as part of a
wide String API change:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsCSSStyleSheet.cpp&branch=&root=/cvsroot&subdir=mozilla/content/html/style/src&command=DIFF_FRAMESET&rev1=3.204&rev2=3.205

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 138165 [details] [diff] [review]
Also fixes case-sensitivity for substring selector

I'll check this in shortly...

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-12-30 09:58 -0800.  Thanks for the patch.