Closed
Bug 229177
Opened 21 years ago
Closed 21 years ago
TestXMLExtras crashes at shutdown
Categories
(Core :: XML, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.7alpha
People
(Reporter: keeda, Assigned: keeda)
Details
(Keywords: crash)
Attachments
(1 file)
|
1.94 KB,
patch
|
hjtoi-bugzilla
:
review+
hjtoi-bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
A while back, I was trying to use TestXMLExtras to isolate some leak. I found it
was unusable since I kept running into shutdown leaks and crashes. It calls
xpcom shutdown while still holding on to references to some xpcom objects.
|
Assignee | |
Comment 1•21 years ago
|
||
This fixed all the shutdown problems. TestXMLExtras doesn't crash on shutdown
in a debug build with this patch.
|
|
Assignee | |
Comment 2•21 years ago
|
||
Comment on attachment 137839 [details] [diff] [review]
Simple fix. Just let go of all strong ref before calling shutdown.
Heikki could you please r+sr. This is pretty trivial and affects only test
code.
Attachment #137839 -
Flags: review?(hjtoi-bugzilla)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.7alpha
|
||
Updated•21 years ago
|
Attachment #137839 -
Flags: superreview+
Attachment #137839 -
Flags: review?(hjtoi-bugzilla)
Attachment #137839 -
Flags: review+
|
|
Assignee | |
Updated•21 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•