Closed
Bug 229193
Opened 21 years ago
Closed 21 years ago
Some signed/unsigned problems in dsautil.c
Categories
(NSS :: Libraries, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.9
People
(Reporter: wtc, Assigned: rrelyea)
Details
Attachments
(1 file)
|
1.64 KB,
patch
|
rrelyea
:
review+
bugz
:
superreview+
|
Details | Diff | Splinter Review |
The 'len' local variables and arguments in dsautil.c
should be unsigned int rather than int.
Some of these problems would have been discovered
sooner if dsautil.c had included cryptohi.h, which
declares the functions in question with the correct
types for the 'len' arguments.
|
Reporter | |
Comment 1•21 years ago
|
||
1. Include cryptohi.h, which declares the functions
defined in dsautil.c.
2. Use the type 'unsigned int' for 'len'.
|
|
Reporter | |
Updated•21 years ago
|
Attachment #137850 -
Flags: superreview?(bugz)
Attachment #137850 -
Flags: review?(rrelyea0264)
|
|
Reporter | |
Comment 2•21 years ago
|
||
Bob, please check this patch in if you think it is
correct.
Assignee: wchang0222 → rrelyea0264
Priority: -- → P2
Target Milestone: --- → 3.9
|
||
Updated•21 years ago
|
Attachment #137850 -
Flags: superreview?(bugz) → superreview+
|
Assignee | |
Comment 3•21 years ago
|
||
Comment on attachment 137850 [details] [diff] [review]
Proposed patch
yes, it looks good.
Attachment #137850 -
Flags: review?(rrelyea0264) → review+
|
|
Assignee | |
Comment 4•21 years ago
|
||
relyea(19) cvs commit
cvs commit: Examining .
Checking in dsautil.c;
/cvsroot/mozilla/security/nss/lib/cryptohi/dsautil.c,v <-- dsautil.c
new revision: 1.6; previous revision: 1.5
done
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•